doc: ChangeLog as Markdown and ChangeLog for io.js v1.0.0 #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rvagg I suggest renaming the file to |
|
review by at least one @iojs/tc member please to sign-off on the conversion to markdown, it's pretty heavy-handed but I believe the integrity of the document is kept further discussion on markdownifying is in #194 (I only just realised it was a PR and not an Issue so I've duplicated that work!) |
|
Except @fixe comment, LGTM. Would be cool to have some native speaker to sign-off it too |
|
renamed file, thanks, the inconsistency has been bugging me too |
Conversion of the ChangeLog includes headings, compacted lists, links for commits to GitHub (iojs/io.js) and links to issues on GitHub (joyent/node)
Collaboratively edited by many people in https://code.stypi.com/domenic/iojs-1.0-changelog.md and includes a summary of changes in each major section of the project from a user-facing perspective from Node.js v0.10.34 to io.js v1.0.0. Renamed file to CHANGELOG.md from ChangeLog.md Fixes: nodejs#339
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 23, 2022
Commit dae283d from August 2020 introduced a call to EntropySource() in SecretKeyGenTraits::DoKeyGen() in src/crypto/crypto_keygen.cc. There are two problems with that: 1. It does not check the return value, it assumes EntropySource() always succeeds, but it can (and sometimes will) fail. 2. The random data returned byEntropySource() may not be cryptographically strong and therefore not suitable as keying material. An example is a freshly booted system or a system without /dev/random or getrandom(2). EntropySource() calls out to openssl's RAND_poll() and RAND_bytes() in a best-effort attempt to obtain random data. OpenSSL has a built-in CSPRNG but that can fail to initialize, in which case it's possible either: 1. No random data gets written to the output buffer, i.e., the output is unmodified, or 2. Weak random data is written. It's theoretically possible for the output to be fully predictable because the CSPRNG starts from a predictable state. Replace EntropySource() and CheckEntropy() with new function CSPRNG() that enforces checking of the return value. Abort on startup when the entropy pool fails to initialize because that makes it too easy to compromise the security of the process. Refs: https://hackerone.com/bugs?report_id=1690000 Refs: #35093 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> PR-URL: #346 Backport-PR-URL: #351 CVE-ID: CVE-2022-35255
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #339
two separate commits here because the conversion should be separate