Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix ChangeLog file type to .md #194

Closed
wants to merge 1 commit into from

Conversation

PatrickJS
Copy link

No description provided.

@ilanbiala
Copy link

This seems like a good start towards making the changelog much better. We should definitely add in some links for some of those SHAs and tag people's GitHub profiles when we mention them in the changelog. Also, should it just be changelog.md or CHANGELOG.md or History.md, but not ChangeLog.md?

@PatrickJS
Copy link
Author

CHANGELOG.md seems to be a popular option and it's very clear to the developer. I can update the changelog with the correct SHAs links

@ilanbiala
Copy link

@gdi2290 you may want to just wait for confirmation from someone on the core io.js team. @bnoordhuis @chrisdickinson @rvagg any thoughts on whether @gdi2290 should continue?

@ruimarinho
Copy link

What about using something like github-changes (or a similar process) to generate a changelog that parses github PRs? See this example output.

@ilanbiala
Copy link

@ruimarinho probably too cutting-edge right now..is there one that's more developed?

@ruimarinho
Copy link

Not from my experience - I haven't found any as simple and straightforward as this one. In this case, regardless of the tool, linking the changes to individual PRs would be a plus, considering that all changes go through an open discussion on github.

@rvagg
Copy link
Member

rvagg commented Dec 23, 2014

I'm a fan of CHANGELOG.md (the name and using Markdown) but would rather defer to the long-standing Node contributors on this one.

@ilanbiala
Copy link

@rvagg do you generate the changelog for nan manually, or with some sort of generator?

@sam-github
Copy link
Contributor

I really, really like the format of the tools @ruimarinho mentioned, in particular the link of the individual changes to their PR. Changelogs are frankly incomprehensible, pretty much, they have barely enough information in them to be useful to someone who already knows the changes when they are doing a quick check to see what release a change came out in.

For someone reading the changelog who wants to understand what actually happened, pasting commit titles into github's search box is a PITA, the inline links really help simplify that.

@rvagg
Copy link
Member

rvagg commented Dec 25, 2014

@ilanbiala generated by hand, with a short release cycle it doesn't take too much effort for a human to browse the commit log and turn it into an interesting list. I'm not so interested in auto-generated ones as commit logs don't tend to translate well to those outside the core of a project.

@fixe
Copy link
Contributor

fixe commented Jan 9, 2015

+1 on curating a CHANGELOG.md based on something generated by a tool like github-changes that only takes PRs into account.

@piscisaureus
Copy link
Contributor

It happened in 16f7fa7

@PatrickJS PatrickJS deleted the change-log branch January 14, 2015 04:15
@PatrickJS
Copy link
Author

I would prefer it if someone gave me the green light or at least accept the PR by updating it manually :/

@rvagg
Copy link
Member

rvagg commented Jan 14, 2015

@gdi2290 sorry, I went ahead and did this not realising this was a pull request, I had it in my head that it was just an issue and need the work done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants