doc: add link to code ide configs #32767
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
reviewed
Apr 10, 2020
There was a problem hiding this comment.
I’ve no firm opinion on this since I don’t use an IDE. There was some discussion in #24012 as to whether the link went in the building or contributing document.
himself65
approved these changes
Apr 10, 2020
Previously it was specific to debug/running with nodejs/node-code-ide-configs#6 I think this is also an appropriate place. |
|
I notice that we already have the description in doc. |
trivikr
approved these changes
Apr 10, 2020
ronag
added
the
author ready
|
oh, no. I push this PR by mistake with no reviewers message. force pushed |
himself65
pushed a commit
that referenced
this pull request
Apr 13, 2020
Refs: #32764 PR-URL: #32767 Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
|
Landed in cf888ac |
targos
pushed a commit
that referenced
this pull request
Apr 13, 2020
Refs: #32764 PR-URL: #32767 Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 14, 2020
Refs: #32764 PR-URL: #32767 Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
Refs: #32764 PR-URL: #32767 Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #32764
Checklist