Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: How to get eslint to work on VS code? #32764

Closed
ronag opened this issue Apr 10, 2020 · 8 comments
Closed

docs: How to get eslint to work on VS code? #32764

ronag opened this issue Apr 10, 2020 · 8 comments
Labels
question Issues that look for answers.

Comments

@ronag
Copy link
Member

ronag commented Apr 10, 2020

I previously received some help with this. Unfortunately I didn't document it and after re-installing my computer it no longer works.

Would anyone mind describing how to get it to work? I'll add a section in the docs for future reference.

@himself65 himself65 added the question Issues that look for answers. label Apr 10, 2020
@himself65
Copy link
Member

I use Webstorm, and I think they are same (in some places), like eslint package and conf file

hope this could help you out.

image

@himself65
Copy link
Member

himself65 commented Apr 10, 2020

I try vscode and work out the success configuration file.

{
    "eslint.format.enable": true,
    "eslint.nodePath": "./tools/node_modules/eslint",
    "eslint.options": {
        "configFile": "./.eslintrc.js"
    },
    "eslint.validate": [
        "javascript"
    ]
}

obviously, you have to download the eslint extension in vscode shop

example

image

@ronag
Copy link
Member Author

ronag commented Apr 10, 2020

I try vscode and work out the success configuration file

Where is this? Also I don't want this to apply globally as I work with other projects as well...

@ronag
Copy link
Member Author

ronag commented Apr 10, 2020

Ah, workspace specific settings. Perfect. Thank you!

@ronag
Copy link
Member Author

ronag commented Apr 10, 2020

Would it make sense to include a .vscode folder into repro with these settings?

@himself65
Copy link
Member

I think no, people don't use the same Editor or IDE. and we shouldn't include any of its configuration files in the repo.

But document to introduce it may be ok

@richardlau
Copy link
Member

Would it make sense to include a .vscode folder into repro with these settings?

https://github.com/nodejs/node-code-ide-configs

@ronag
Copy link
Member Author

ronag commented Apr 10, 2020

@ronag ronag closed this as completed Apr 10, 2020
ronag added a commit to nxtedition/node that referenced this issue Apr 10, 2020
himself65 pushed a commit that referenced this issue Apr 13, 2020
Refs: #32764
PR-URL: #32767
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this issue Apr 13, 2020
Refs: #32764
PR-URL: #32767
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
BethGriggs pushed a commit that referenced this issue Apr 14, 2020
Refs: #32764
PR-URL: #32767
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this issue Apr 22, 2020
Refs: #32764
PR-URL: #32767
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Issues that look for answers.
Projects
None yet
Development

No branches or pull requests

3 participants