v12.11.1 release proposal #29796
Merged
v12.11.1 release proposal #29796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: #29666 Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #29732 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
PR-URL: #29700 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #29738 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
So that the stack trace of errors shown in internal code run during bootstrap (before process._fatalException is set) can be printed. PR-URL: #29624 Refs: #29593 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
So that coverage, .etc are properly written in case of a normal fatal exception. PR-URL: #29611 Fixes: #29570 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Ben Coe <[email protected]>
This is to accommodate Myles Borins otherwise ending up with multiple entries due to different casing in the email 🙂 PR-URL: #29608 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Saúl Ibarra Corretgé <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #29608 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Saúl Ibarra Corretgé <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Keep the `ArrayBuffer::Allocator` behind a `SharedArrayBuffer` instance alive for at least as long as the receiving Isolate lives, if the `SharedArrayBuffer` instance isn’t already destroyed through GC. This is to work around the fact that V8 7.9 started refactoring how backing stores for `SharedArrayBuffer` instances work, changing the timing of the call that releases the backing store to be during Isolate disposal. The flag added to the test is optional but helps verify that the backing store is actually free’d at the end of the test and does not leak memory. Fixes: nodejs/node-v8#115 PR-URL: #29637 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
This adds `null` to the supported types of the `iv` option when using `crypto.createCipheriv()`. PR-URL: #29684 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Documents that callback is optional for IncomingMessage setTimeout PR-URL: #29654 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #29657 Co-authored-by: ZaneHannanAU <[email protected]> Co-authored-by: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Currently, the following compiler warnings is generated: ../src/inspector_profiler.cc:231:5: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result] profile->Set(context, FIXED_ONE_BYTE_STRING(isolate, "source-map-cache") ^~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. This commit adds a .ToChecked() call to avoid the warning. PR-URL: #29660 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #29673 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: James M Snell <[email protected]>
Add missing header for LSAN. PR-URL: #29383 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
This is obsolete. Also, in our case it doesn't seem to have any effect since the table cells have their natural width, i.e. as much as they need. PR-URL: #29668 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: David Carlier <[email protected]>
For `www.cve.mitre.org` they don't seem to redirect www to naked. PR-URL: #29661 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #29670 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #29688 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Errors should be propagated through destroy(err). Anything else is basically undefined behaviour. PR-URL: #29653 Refs: #29584 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
PR-URL: #29687 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #29689 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #29711 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
This makes sure `process._fatalException()` returns a boolean when run inside of a worker. PR-URL: #29706 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
When running `vcbuild lint` on a new prompt where vcbuild was not run before, `%node_exe%` was not defined and `eslint.js`, `lint-js.js` and `lint-md.js` would be run directly using the program defined in Windows (usually the Windows Scripting Host or Notepad). This moves the goto statement to after `%node_exe%` is defined. Fixes: #29602 PR-URL: #29616 Reviewed-By: Ruben Bridgewater <[email protected]>
Builds from the source tarball were broken by the recent V8 upate to 7.7 as a file needed to build torque wasn't included in the source tarball as it resides in deps/v8/test. PR-URL: #29712 Fixes: #29709 Refs: #28918 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
The Node.js security disclosure policy has diverged between the website and github: - https://nodejs.org/en/security/ - https://github.com/nodejs/node/security/policy The website is more recent and accurate, so sync the content from: - https://github.com/nodejs/nodejs.org/blob/master/locale/en/security.md PR-URL: #29682 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
The following pattern is redundant, so remove it: if (options.foo !== undefined) this.foo = options.foo; else this.foo = undefined; PR-URL: #29704 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #29736 Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: David Carlier <[email protected]>
The data are needed for new Intl.NumberFormat options added by V8. Fixes: #29734 PR-URL: #29735 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2019-10-01, Version 12.11.1 (Current), @targos
Notable changes
the official source tarball (Richard Lau) #29712.
Intl.NumberFormatAPI (Michaël Zasso) #29735.Commits
35e1d8c5ba] - build: include deps/v8/test/torque in source tarball (Richard Lau) #29712ae461964a7] - build,win: goto lint only after defining node_exe (João Reis) #29616588b388181] - crypto: use byteLength in timingSafeEqual (Tobias Nießen) #29657298d92785c] - deps: enable unit data in small-icu (Michaël Zasso) #297350041f1c0d3] - doc: sync security policy with nodejs.org (Sam Roberts) #29682038cbb08de] - doc: fix output in inspector HeapProfile example (Kirill Fomichev) #29711d86f10cf0b] - doc: add KeyObject to type for crypto.createDecipheriv() argument (exoego) #296891303e3551f] - doc: clarify description ofreadable.push()method (imhype) #29687d258e0242c] - doc: clarify stream errors while reading and writing (Robert Nagy) #296530fc85ff96a] - doc: specifydisplay=fallbackfor Google Fonts (XhmikosR) #29688c2791dcd9c] - doc: fix some recent nits (Vse Mozhet Byt) #296707a6b05a26f] - doc: fix 404 links (XhmikosR) #296612b76cb6dda] - doc: remove align from tables (XhmikosR) #296683de1fc6958] - doc: document that iv may be null when using createCipheriv() (Ruben Bridgewater) #2968491e4cc7500] - doc: update AUTHORS list (Anna Henningsen) #296082ea4cc0732] - doc: clarify pipeline stream cleanup (Robert Nagy) #29738ab060bfdab] - doc: clarify fs.symlink() usage (Simon A. Eugster) #29700b5c24dfbe8] - doc: fix type of atime/mtime (TATSUNO Yasuhiro) #296666579b1a547] - doc,http: indicate callback is optional for message.setTimeout() (Trivikram Kamat) #29654a04fc86723] - http2: optimize the altsvc Max bytes limit, define and use constants (rickyes) #29673d1f4befd09] - module: pass full URL to loader for top-level load (Guy Bedford) #297363f028551a8] - module: move cjs type check behind flag (Guy Bedford) #29732c3a1303bc2] - src: rename --loader to --experimental-loader (Alex Aubuchon) #2975217c3478d78] - src: fix asan build for gcc/clang (David Carlier) #2938364740d44b5] - src: fix compiler warning in inspector_profiler.cc (Daniel Bevenius) #29660a86b71f745] - src: disconnect inspector before exiting out of fatal exception (Joyee Cheung) #296118d88010277] - src: try showing stack traces when process._fatalException is not set (Joyee Cheung) #296242a6b7b0476] - test: fix flaky test-cluster-net-listen-ipv6only-none (Rich Trott) #2968169f26340e9] - tls: simplify setSecureContext() option parsing (cjihrig) #29704c361180c07] - tools: make mailmap processing for author list case-insensitive (Anna Henningsen) #29608ef033d046a] - worker: fix process._fatalException return type (Ruben Bridgewater) #2970604df7dbadb] - worker: keep allocators for transferred SAB instances alive longer (Anna Henningsen) #29637