-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix 404 links #29661
doc: fix 404 links #29661
Conversation
If anyone's in touch with mitre.org they should ask them to fix the www to naked redirection on their side. Weird that no one noticed this before. |
BTW this is ongoing. I'm doing a first pass without scanning some links like github.com. I'm gonna update nodejs/nodejs.org#2424 when the scan is done requesting feedback for each link, but I'll push here any fixes in core docs in separate PRs. I'll keep this PR only for changelogs. |
For `www.cve.mitre.org` they don't seem to redirect www to naked.
I only found one more real broken link Should I change this in this PR too? This could probably be backported, though. |
What should I do about the broken |
Let's do that in a separate PR. This way any discussion there won't delay these other fixes. For example, there might be discussion about using the official V8 docs somehow rather than NodeSource (although I seem to recall there was a good reason to use NodeSource, but I don't recall what it was!). |
Landed in f81bef5 |
For `www.cve.mitre.org` they don't seem to redirect www to naked. PR-URL: #29661 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
For `www.cve.mitre.org` they don't seem to redirect www to naked. PR-URL: #29661 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes