Extra patches for rename #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM but you need to trim those commit logs, Bertje. :-) Yes, the OS X installer needs work but I haven't looked into that; I really have no idea how OS X packaging works. |
|
@bnoordhuis ok, ptal. Your patches lgtm too, I'll rebase on top of yours after you land yours. |
|
#262 landed so go ahead and rebase. I'll start reviewing. |
PR-URL: nodejs#263 Reviewed-By: Ben Noordhuis <[email protected]>
PR-URL: nodejs#263 Reviewed-By: Ben Noordhuis <[email protected]>
PR-URL: nodejs#263 Reviewed-By: Ben Noordhuis <[email protected]>
PR-URL: nodejs#263 Reviewed-By: Ben Noordhuis <[email protected]>
* Sign iojs.exe * Run license2rtf.js through iojs PR-URL: nodejs#263 Reviewed-By: Ben Noordhuis <[email protected]>
This change is strictly limited to the name of the binary. The shortcut name, install folder, docs website links etc. are all unchanged. PR-URL: nodejs#263 Reviewed-By: Ben Noordhuis <[email protected]>
PR-URL: nodejs#263 Reviewed-By: Ben Noordhuis <[email protected]>
|
@bnoordhuis rebased |
|
LGTM with one suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's some extra work I had to do to make it build on windows.
Your changes lgtm but I can't tell if that's all that's needed.
It seems that the mac installer should get updated and textual references to node also need to be replaced.
@bnoordhuis