build: rename binary from node to iojs #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For targets that need the binary: don't invoke `make all` as part of the recipe, just depend on the $(NODE_EXE) target. PR-URL: nodejs#262 Reviewed-By: Bert Belder <[email protected]>
The targets upload to nodejs.org but that is the joyent/node website. PR-URL: nodejs#262 Reviewed-By: Bert Belder <[email protected]>
PR-URL: nodejs#262 Reviewed-By: Bert Belder <[email protected]>
The binary is about to be renamed from `node` to `iojs`; preemptively update the man page. PR-URL: nodejs#262 Reviewed-By: Bert Belder <[email protected]>
Update the outdated list of V8 options in the man page. PR-URL: nodejs#262 Reviewed-By: Bert Belder <[email protected]>
The flag was used for a short while during the v0.5 development cycle, four years ago. Remove it, it's long overdue. PR-URL: nodejs#262 Reviewed-By: Bert Belder <[email protected]>
* rename the build targets
* update the test runner to use `out/{Debug,Release}/iojs`
* update the installer to install the iojs binary
* update one test that explicitly checks for the binary name
PR-URL: nodejs#262
Reviewed-By: Bert Belder <[email protected]>
Install a symlink for compatibility with scripts that expect a binary called `node` or have a /path/to/node shebang. Only done on UNIX platforms because symlinks on Windows require elevated privileges. PR-URL: nodejs#262 Reviewed-By: Bert Belder <[email protected]>
|
More work needs to be done, but this all lgtm |
bnoordhuis
force-pushed
the
rename-binary
branch
from
9d53d9c
to
72f1b34
Compare
|
Landed in b5c9dcb...72f1b34 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R=@piscisaureus