[v8.x] Backport tty fixes #25351
Closed
[v8.x] Backport tty fixes #25351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since faking TTY input is not otherwise fake-able, we need support in the test runner for it. PR-URL: nodejs#23053 Reviewed-By: James M Snell <[email protected]>
Allow reading from stdio streams that are conventionally associated with process output, since this is only convention. This involves disabling the oddness around closing stdio streams. Its purpose is to prevent the file descriptors 0 through 2 from being closed, since doing so can lead to information leaks when new file descriptors are being opened; instead, not doing anything seems like a more reasonable choice. Fixes: nodejs#21203 PR-URL: nodejs#23053 Reviewed-By: James M Snell <[email protected]>
Make sure that `process.stdin.write()`, and in particular ending the stream, works. PR-URL: nodejs#23053 Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs#23051 Fixes: nodejs#22814 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: George Adams <[email protected]> Reviewed-By: James M Snell <[email protected]>
mcollina
added
the
semver-minor
nodejs-github-bot
added
errors
|
cc @nodejs/lts is this something that is of interest in a future 8.x release? Or should this be closed? |
BethGriggs
pushed a commit
that referenced
this pull request
Mar 19, 2019
Since faking TTY input is not otherwise fake-able, we need support in the test runner for it. Backport-PR-URL: #25351 PR-URL: #23053 Reviewed-By: James M Snell <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Mar 19, 2019
Allow reading from stdio streams that are conventionally associated with process output, since this is only convention. This involves disabling the oddness around closing stdio streams. Its purpose is to prevent the file descriptors 0 through 2 from being closed, since doing so can lead to information leaks when new file descriptors are being opened; instead, not doing anything seems like a more reasonable choice. Fixes: #21203 Backport-PR-URL: #25351 PR-URL: #23053 Reviewed-By: James M Snell <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Mar 19, 2019
Make sure that `process.stdin.write()`, and in particular ending the stream, works. Backport-PR-URL: #25351 PR-URL: #23053 Reviewed-By: James M Snell <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Mar 19, 2019
Backport-PR-URL: #25351 PR-URL: #23051 Fixes: #22814 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: George Adams <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed on v8.x-staging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #25204
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes