Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add process.stdin.end() TTY regression test #23051

Closed
wants to merge 1 commit into from
Closed

test: add process.stdin.end() TTY regression test #23051

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Fixes: #22814

Taken from @mcollina’s #22900.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/992/pipeline

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. tty Issues and PRs related to the tty subsystem. labels Sep 24, 2018
mcollina
mcollina approved these changes Sep 24, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you also include a revert for my semver-major fix retaining tests? It should not be needed anymore (another PR is also ok).

@addaleax
Copy link
Member Author

@mcollina Will do, but another PR might be easier since it’s going to be dont-land-on-v10.x…

@mcollina
Copy link
Member

mcollina commented Sep 24, 2018 via email

@danbev
Copy link
Contributor

danbev commented Sep 27, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17462/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 28, 2018
@addaleax
Copy link
Member Author

Rebuild: https://ci.nodejs.org/job/node-test-pull-request/17480/

@addaleax
Copy link
Member Author

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/17500/

@addaleax
Copy link
Member Author

Again: https://ci.nodejs.org/job/node-test-pull-request/17520/

@joyeecheung joyeecheung mentioned this pull request Oct 2, 2018
Closed
@addaleax
Copy link
Member Author

addaleax commented Oct 3, 2018 •
edited by danbev
Loading

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/17610/ ✔️

@danbev
Copy link
Contributor

danbev commented Oct 4, 2018

Landed in 9577946.

@danbev danbev closed this Oct 4, 2018
danbev pushed a commit that referenced this pull request Oct 4, 2018
@mcollina @danbev
test: add process.stdin.end() TTY regression test
9577946 
PR-URL: #23051
Fixes: #22814
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: George Adams <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Oct 4, 2018
@mcollina @targos
test: add process.stdin.end() TTY regression test
748d9d2 
PR-URL: #23051
Fixes: #22814
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: George Adams <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Oct 7, 2018
Merged
@addaleax addaleax deleted the test-tty-stdin-end branch October 7, 2018 23:18
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
This was referenced Oct 11, 2018
Closed
Closed
Closed
Closed
Closed
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@mcollina @jasnell
test: add process.stdin.end() TTY regression test
d71d3ef 
PR-URL: #23051
Fixes: #22814
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: George Adams <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This was referenced Oct 23, 2018
Closed
Closed
BethGriggs pushed a commit that referenced this pull request Mar 19, 2019
@mcollina @BethGriggs
test: add process.stdin.end() TTY regression test
b4c5435 
Backport-PR-URL: #25351
PR-URL: #23051
Fixes: #22814
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: George Adams <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 26, 2019
Merged
abhishekumar-tyagi pushed a commit to abhishekumar-tyagi/node that referenced this pull request May 5, 2024
@mcollina
test: add process.stdin.end() TTY regression test
8d6637f 
PR-URL: nodejs/node#23051
Fixes: nodejs/node#22814
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: George Adams <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdams gdams gdams approved these changes

@trivikr trivikr trivikr approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests. tty Issues and PRs related to the tty subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ENOTCONN thrown when calling process.stdin.end() in node 10.1.0
9 participants
@addaleax @nodejs-github-bot @mcollina @danbev @jasnell @lpinca @cjihrig @trivikr @gdams