src: fix compiler warnings

[cjihrig]

The warnings in question are:

../src/node.cc:844:13: warning: unused function 'DebugProcess' [-Wunused-function]
static void DebugProcess(const FunctionCallbackInfo<Value>& args);
            ^
../src/node.cc:845:13: warning: unused function 'DebugEnd' [-Wunused-function]
static void DebugEnd(const FunctionCallbackInfo<Value>& args);

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[nodejs-github-bot]

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2025/pipeline

[richardlau]

In case anyone else was wondering, the functions being referred to were moved in #25127.

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/19766/ ✔️

[Trott]

The quoted error messages in the commit message are longer than 72 characters. What do we normally do in this case? Land it as-is? Wrap the error message even though that's altering quoted output? Move the error messages to a gist or something and link there?

[cjihrig]

I'm not sure if we have a general policy on that. In this particular case, [-Wunused-function] is not important and can be dropped.

[danbev]

The quoted error messages in the commit message are longer than 72 characters. What do we normally do in this case? Land it as-is?

I usually line break it and try to make sure that the ^ still lines up:

../src/node.cc:844:13: warning:
unused function 'DebugProcess' [-Wunused-function]
static void DebugProcess(const FunctionCallbackInfo<Value>& args);
                ^
../src/node.cc:845:13: warning:
unused function 'DebugEnd' [-Wunused-function]
static void DebugEnd(const FunctionCallbackInfo<Value>& args);

I'll do that for this as well but let me know if I should be doing something different in the future.

[danbev]

Landed in e7e26b2. 🎄

[MylesBorins]

landing this on v11.x causes there to be an error as the symbol is still being used. Unfortunately as the commit meta data was not included in the commit when it landed on master there will be no way for our current tooling to ignore this commit when auditing master for v11.x

We likely want to revisit this and try and come up with a solution so it doesn't keep showing up as a false positive when auditing

[danbev]

@MylesBorins I really sorry about this 😞 Is there anything I can do to fix this or is it too late?
Would it help if I reverted this and commit with the metadata?

[MylesBorins]

We'll figure it out, not the end of the world. Post was more for documentation and follow up.

…

On Tue, Dec 25, 2018, 3:01 AM Daniel Bevenius ***@***.*** wrote: @MylesBorins <https://github.com/MylesBorins> I really sorry about this 😞 Is there anything I can do to fix this or is it too late? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#25165 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAecVxvuY_Ee_xaCxXpmFcO4anCYcT_oks5u8dtCgaJpZM4ZeCrn> .