Skip to content

Commit

Permalink
src: fix compiler warnings
Browse files Browse the repository at this point in the history 
The warnings in question are:

../src/node.cc:844:13: warning:
unused function 'DebugProcess' [-Wunused-function]
static void DebugProcess(const FunctionCallbackInfo<Value>& args);
            ^
../src/node.cc:845:13: warning:
unused function 'DebugEnd' [-Wunused-function]
static void DebugEnd(const FunctionCallbackInfo<Value>& args);
  • Loading branch information
@cjihrig @danbev
cjihrig authored and danbev committed Dec 24, 2018
1 parent 457603e commit e7e26b2
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions src/node.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -841,9 +841,6 @@ static Local<Object> GetFeatures(Environment* env) {
return scope.Escape(obj);
}

static void DebugProcess(const FunctionCallbackInfo<Value>& args);
static void DebugEnd(const FunctionCallbackInfo<Value>& args);

void SetupProcessObject(Environment* env,
const std::vector<std::string>& args,
const std::vector<std::string>& exec_args) {
Expand Down

1 comment on commit e7e26b2

@MylesBorins
Copy link
Contributor

@MylesBorins MylesBorins commented on e7e26b2 Dec 25, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing meta data on this commit unfortunately

PR-URL: #25165

landing this on v11.x causes there to be an error as the symbol is still being used. Unfortunately as the commit meta data was not included in the commit when it landed on master there will be no way for our current tooling to ignore this commit when auditing master for v11.x

We likely want to revisit this and try and come up with a solution so it doesn't keep showing up as a false positive when auditing

Please sign in to comment.