v10.14.1 proposal #24711
v10.14.1 proposal #24711
Conversation
Clarify the behavior of what Boxstarter may do when it runs on a box to install all the necessary tools so that there are no surprises to the end user when the script is run. Currently there is no interface that warns the user that Boxstarter will reboot the machine possibly multiple times depending on how many dependencies need to be installed and doesn't mention a need to disable UAC. For folks who see what may look like a reboot loop, we feel it is necessary to make them aware that UAC will be disabled and they will need to take action to re-enable UAC manually if they interfere/stop the script from finishing. PR-URL: #23987 Fixes: nodejs/Release#369 Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Fixes: nodejs/Release#369 PR-URL: #23987 Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]>
This reverts: Revision: 257a5e9 win: add prompt to tools installation script Revision: e9a2915 win: clarify Boxstarter behavior on install tools Revision: 3b895d1 win,msi: display license notes before installing tools Revision: cf284c8 win,msi: install Boxstarter from elevated shell Revision: 2b7e18d win,msi: highlight installation of 3rd-party tools Revision: ebf36cd win,msi: install tools for native modules PR-URL: #24344 Refs: #22645 Refs: #23987 Refs: nodejs/Release#369 Refs: #23838 Refs: nodejs/security-wg#439 Reviewed-By: João Reis <[email protected]> Reviewed-By: Richard Lau <[email protected]>
nodejs-github-bot
added
lib / src
|
@nodejs/release @nodejs/lts @nodejs/tsc I've been reading on and off about the changes to our MSI installed biting people. I know this is being figured out on master but we really can't be having this continue to bite people on LTS, especially if they are attempting to update to the security release. This small release, which I would like to get out tomorrow, only lands the changes necessary to revert the installer changes, it landed in #24344. My plan is to release this tomorrow, likely earlier in the day. Apologies for the rush on this but I genuinely don't think we should be waiting any longer on this. I'm going to kick off all the bits and if there are no objections in the next 11 hours I plan to do this release at 11:00am ET. |
Notable Changes: * **win/msi**: Revert changes to installer causing issues on Windows systems. PR-URL: #24711
MylesBorins
force-pushed
the
v10.14.1-proposal
branch
from
179cdb6
to
d3dbe3a
Compare
There was a problem hiding this comment.
@MylesBorins thanks for making a release to move this forward.
#24677 is open for master and should fix all the issues we've seen so far.
There was a problem hiding this comment.
LGTM, except that I don't really like having commits that introduce changes just to undo them again. But if backports without those two is really hard then it's your call.
@joaocgreis please weigh in here, your 👍 on an expedited release would be appreciated, alternatively if you don't think it's necessary to rush that would also be good to hear. You're much better connected to the Windows world than most of us.
|
@rvagg I could squash them all into one commit but I didn't want to land stuff that hadn't been reviewed. |
|
@rvagg @MylesBorins to be clear, please go ahead with this. It will be good to get this out in a release as soon as possible. |
|
arm failure is known flake fixed on master: #23406 |
Notable Changes: * **win/msi**: Revert changes to installer causing issues on Windows systems. PR-URL: #24711
Notable Changes: * **win/msi**: Revert changes to installer causing issues on Windows systems. PR-URL: nodejs#24711
2018-11-29, Version 10.14.1 'Dubnium' (LTS), @MylesBorins
Notable Changes
Commits
5d17bf1e13] - win: add prompt to tools installation script (João Reis) #23987589f0d2192] - win: clarify Boxstarter behavior on install tools (Rob Reynolds) #239879e293c1328] - Revert "win,msi: install tools for native modules" (Refael Ackermann) #24344