windows 10, nodejs 10.12.0 boxstarter dependency force reboot #369
Comments
|
cc @nodejs/platform-windows and @joaocgreis @tniessen as per possibly related PRs: |
|
Rebooting is essential to install those tools reliably. @danjo133 the fact that your machine rebooted 4 times is a strong indication that the installation would have failed if not allowed to reboot. The script warns about this: |
|
Well it did warn, but I believe it's not noticeable enough, for many users simply press Enter or whatever when they see |
2 tasks
joaocgreis
added a commit
to JaneaSystems/node
that referenced
this issue
Oct 31, 2018
2 tasks
joaocgreis
added a commit
to JaneaSystems/node
that referenced
this issue
Oct 31, 2018
Trott
pushed a commit
to Trott/io.js
that referenced
this issue
Nov 4, 2018
Fixes: nodejs/Release#369 PR-URL: nodejs#23987 Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]>
MylesBorins
pushed a commit
to nodejs/node
that referenced
this issue
Nov 4, 2018
Clarify the behavior of what Boxstarter may do when it runs on a box to install all the necessary tools so that there are no surprises to the end user when the script is run. Currently there is no interface that warns the user that Boxstarter will reboot the machine possibly multiple times depending on how many dependencies need to be installed and doesn't mention a need to disable UAC. For folks who see what may look like a reboot loop, we feel it is necessary to make them aware that UAC will be disabled and they will need to take action to re-enable UAC manually if they interfere/stop the script from finishing. PR-URL: #23987 Fixes: nodejs/Release#369 Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]>
MylesBorins
pushed a commit
to nodejs/node
that referenced
this issue
Nov 4, 2018
Fixes: nodejs/Release#369 PR-URL: #23987 Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]>
targos
pushed a commit
to nodejs/node
that referenced
this issue
Nov 5, 2018
Clarify the behavior of what Boxstarter may do when it runs on a box to install all the necessary tools so that there are no surprises to the end user when the script is run. Currently there is no interface that warns the user that Boxstarter will reboot the machine possibly multiple times depending on how many dependencies need to be installed and doesn't mention a need to disable UAC. For folks who see what may look like a reboot loop, we feel it is necessary to make them aware that UAC will be disabled and they will need to take action to re-enable UAC manually if they interfere/stop the script from finishing. PR-URL: #23987 Fixes: nodejs/Release#369 Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]>
targos
pushed a commit
to nodejs/node
that referenced
this issue
Nov 5, 2018
Fixes: nodejs/Release#369 PR-URL: #23987 Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
3 tasks
refack
added a commit
to refack/node
that referenced
this issue
Nov 18, 2018
This reverts: Revision: 257a5e9 win: add prompt to tools installation script Revision: e9a2915 win: clarify Boxstarter behavior on install tools Revision: 3b895d1 win,msi: display license notes before installing tools Revision: cf284c8 win,msi: install Boxstarter from elevated shell Revision: 2b7e18d win,msi: highlight installation of 3rd-party tools Revision: ebf36cd win,msi: install tools for native modules PR-URL: nodejs#24344 Refs: nodejs#22645 Refs: nodejs#23987 Refs: nodejs/Release#369 Refs: nodejs#23838 Refs: nodejs/security-wg#439 Reviewed-By: João Reis <[email protected]> Reviewed-By: Richard Lau <[email protected]>
rvagg
pushed a commit
to nodejs/node
that referenced
this issue
Nov 28, 2018
Clarify the behavior of what Boxstarter may do when it runs on a box to install all the necessary tools so that there are no surprises to the end user when the script is run. Currently there is no interface that warns the user that Boxstarter will reboot the machine possibly multiple times depending on how many dependencies need to be installed and doesn't mention a need to disable UAC. For folks who see what may look like a reboot loop, we feel it is necessary to make them aware that UAC will be disabled and they will need to take action to re-enable UAC manually if they interfere/stop the script from finishing. PR-URL: #23987 Fixes: nodejs/Release#369 Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]>
rvagg
pushed a commit
to nodejs/node
that referenced
this issue
Nov 28, 2018
Fixes: nodejs/Release#369 PR-URL: #23987 Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]>
rvagg
pushed a commit
to nodejs/node
that referenced
this issue
Nov 28, 2018
This reverts: Revision: 257a5e9 win: add prompt to tools installation script Revision: e9a2915 win: clarify Boxstarter behavior on install tools Revision: 3b895d1 win,msi: display license notes before installing tools Revision: cf284c8 win,msi: install Boxstarter from elevated shell Revision: 2b7e18d win,msi: highlight installation of 3rd-party tools Revision: ebf36cd win,msi: install tools for native modules PR-URL: #24344 Refs: #22645 Refs: #23987 Refs: nodejs/Release#369 Refs: #23838 Refs: nodejs/security-wg#439 Reviewed-By: João Reis <[email protected]> Reviewed-By: Richard Lau <[email protected]>
MylesBorins
pushed a commit
to nodejs/node
that referenced
this issue
Nov 29, 2018
Clarify the behavior of what Boxstarter may do when it runs on a box to install all the necessary tools so that there are no surprises to the end user when the script is run. Currently there is no interface that warns the user that Boxstarter will reboot the machine possibly multiple times depending on how many dependencies need to be installed and doesn't mention a need to disable UAC. For folks who see what may look like a reboot loop, we feel it is necessary to make them aware that UAC will be disabled and they will need to take action to re-enable UAC manually if they interfere/stop the script from finishing. PR-URL: #23987 Fixes: nodejs/Release#369 Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]>
MylesBorins
pushed a commit
to nodejs/node
that referenced
this issue
Nov 29, 2018
Fixes: nodejs/Release#369 PR-URL: #23987 Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]>
MylesBorins
pushed a commit
to nodejs/node
that referenced
this issue
Nov 29, 2018
This reverts: Revision: 257a5e9 win: add prompt to tools installation script Revision: e9a2915 win: clarify Boxstarter behavior on install tools Revision: 3b895d1 win,msi: display license notes before installing tools Revision: cf284c8 win,msi: install Boxstarter from elevated shell Revision: 2b7e18d win,msi: highlight installation of 3rd-party tools Revision: ebf36cd win,msi: install tools for native modules PR-URL: #24344 Refs: #22645 Refs: #23987 Refs: nodejs/Release#369 Refs: #23838 Refs: nodejs/security-wg#439 Reviewed-By: João Reis <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When installing nodejs 10.12.0 from https://nodejs.org/dist/v10.12.0/node-v10.12.0-x64.msi the installer asks if the user wants to install some additional dependencies for nodejs modules containing c++-code.
This installs Boxstarter/Chocolatery which, out of the blue, force rebooted my computer with no warning, no option to save files or anything else. For me, it rebooted 4 times during install.
This is acceptable precisely never.
The text was updated successfully, but these errors were encountered: