Code and learn rollup 3

lib/internal/bootstrap/node.js

@@ -632,7 +632,9 @@
           const { kExpandStackSymbol } = NativeModule.require('internal/util');
           if (typeof er[kExpandStackSymbol] === 'function')
             er[kExpandStackSymbol]();
-        } catch (er) {}
+        } catch {
+          // Nothing to be done about it at this point.
+        }
         return false;
       }
 

lib/tls.js

@@ -176,7 +176,7 @@ exports.checkServerIdentity = function checkServerIdentity(hostname, cert) {
         let uri;
         try {
           uri = new URL(name.slice(4));
-        } catch (err) {
+        } catch {
           uri = url.parse(name.slice(4));
           if (!urlWarningEmitted && !process.noDeprecation) {
             urlWarningEmitted = true;

test/addons/load-long-path/test.js

@@ -1,6 +1,6 @@
 'use strict';
 const common = require('../../common');
-if (common.isWOW64)
+if (common.isWindows && (process.env.PROCESSOR_ARCHITEW6432 !== undefined))
   common.skip('doesn\'t work on WOW64');
 
 const fs = require('fs');

test/common/README.md

@@ -213,11 +213,6 @@ Platform check for SunOS.
 
 Platform check for Windows.
 
-### isWOW64
-* [<boolean>]
-
-Platform check for Windows 32-bit on Windows 64-bit.
-
 ### localhostIPv4
 * [<string>]
 

test/common/index.js

@@ -46,7 +46,6 @@ const isMainThread = (() => {
 })();
 
 const isWindows = process.platform === 'win32';
-const isWOW64 = isWindows && (process.env.PROCESSOR_ARCHITEW6432 !== undefined);
 const isAIX = process.platform === 'aix';
 const isLinuxPPCBE = (process.platform === 'linux') &&
                      (process.arch === 'ppc64') &&
@@ -721,7 +720,6 @@ module.exports = {
   isOSX,
   isSunOS,
   isWindows,
-  isWOW64,
   localIPv6Hosts,
   mustCall,
   mustCallAsync,

test/common/index.mjs

@@ -5,7 +5,6 @@ import common from './index.js';
 const {
   isMainThread,
   isWindows,
-  isWOW64,
   isAIX,
   isLinuxPPCBE,
   isSunOS,
@@ -54,7 +53,6 @@ const {
 export {
   isMainThread,
   isWindows,
-  isWOW64,
   isAIX,
   isLinuxPPCBE,
   isSunOS,

test/parallel/test-buffer-failed-alloc-typed-arrays.js

@@ -26,7 +26,7 @@ for (const allocator of allocators) {
       // These allocations are known to fail. If they do,
       // Uint32Array should still produce a zeroed out result.
       allocator(size);
-    } catch (e) {
+    } catch {
       assert.deepStrictEqual(new Uint32Array(10), zeroArray);
     }
   }

test/parallel/test-dgram-send-bad-arguments.js

@@ -28,17 +28,17 @@ const buf = Buffer.from('test');
 const host = '127.0.0.1';
 const sock = dgram.createSocket('udp4');
 
-assert.throws(function() {
+assert.throws(() => {
   sock.send();
 }, TypeError);  // First argument should be a buffer.
 
 // send(buf, offset, length, port, host)
-assert.throws(function() { sock.send(buf, 1, 1, -1, host); }, RangeError);
-assert.throws(function() { sock.send(buf, 1, 1, 0, host); }, RangeError);
-assert.throws(function() { sock.send(buf, 1, 1, 65536, host); }, RangeError);
+assert.throws(() => { sock.send(buf, 1, 1, -1, host); }, RangeError);
+assert.throws(() => { sock.send(buf, 1, 1, 0, host); }, RangeError);
+assert.throws(() => { sock.send(buf, 1, 1, 65536, host); }, RangeError);
 
 // send(buf, port, host)
-assert.throws(function() { sock.send(23, 12345, host); }, TypeError);
+assert.throws(() => { sock.send(23, 12345, host); }, TypeError);
 
 // send([buf1, ..], port, host)
-assert.throws(function() { sock.send([buf, 23], 12345, host); }, TypeError);
+assert.throws(() => { sock.send([buf, 23], 12345, host); }, TypeError);

test/parallel/test-http2-respond-file-fd-invalid.js

@@ -25,7 +25,7 @@ server.on('stream', (stream) => {
   // Get first known bad file descriptor.
   try {
     while (fs.fstatSync(++fd));
-  } catch (e) {
+  } catch {
     // do nothing; we now have an invalid fd
   }
 

test/parallel/test-readline-interface.js

@@ -509,7 +509,7 @@ function isWarned(emitter) {
     });
     try {
       fi.emit('data', 'fooX');
-    } catch (e) { }
+    } catch { }
     fi.emit('data', 'bar');
     assert.strictEqual(keys.join(''), 'fooXbar');
     rli.close();

test/sequential/test-inspector-scriptparsed-context.js

@@ -81,7 +81,7 @@ async function runTests() {
   await session.waitForBreakOnLine(0, 'evalmachine.<anonymous>');
 
   await session.runToCompletion();
-  assert.strictEqual(0, (await instance.expectShutdown()).exitCode);
+  assert.strictEqual((await instance.expectShutdown()).exitCode, 0);
 }
 
 runTests();

test/sequential/test-pipe.js

@@ -75,7 +75,7 @@ const tcp = net.Server(common.mustCall((s) => {
   s.on('data', (d) => {
     tcpLengthSeen += d.length;
     for (let j = 0; j < d.length; j++) {
-      assert.strictEqual(buffer[i], d[j]);
+      assert.strictEqual(d[j], buffer[i]);
       i++;
     }
   });
@@ -103,7 +103,7 @@ function startClient() {
   }, common.mustCall((res) => {
     res.setEncoding('utf8');
     res.on('data', common.mustCall((string) => {
-      assert.strictEqual('thanks', string);
+      assert.strictEqual(string, 'thanks');
       gotThanks = true;
     }));
   }));
@@ -113,5 +113,5 @@ function startClient() {
 
 process.on('exit', () => {
   assert.ok(gotThanks);
-  assert.strictEqual(bufferSize, tcpLengthSeen);
+  assert.strictEqual(tcpLengthSeen, bufferSize);
 });