Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code and learn rollup 3 #23653

Closed
wants to merge 9 commits into from
Closed

Code and learn rollup 3 #23653

wants to merge 9 commits into from

Commits on Oct 14, 2018

  1. test-http2-respond-file-fd-invalid: remove unused "e" from catch

    @Trott
    Stephen Heitman authored and Trott committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    b29f4c0 View commit details
    Browse the repository at this point in the history

  2. test: inline common module boolean

    @ashleysimpson @Trott
    ashleysimpson authored and Trott committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    c006bcb View commit details
    Browse the repository at this point in the history

  3. test: remove unused variable from catch

    @Trott
    Paige Kato authored and Trott committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    71f0c0e View commit details
    Browse the repository at this point in the history

  4. test: removed unused variable 

    Removed an unused variable in test-buffer-failed-alloc-typed-arrays.js.
    @Trott
    Michal Hynek authored and Trott committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    60c0407 View commit details
    Browse the repository at this point in the history

  5. test: fix assert.strictEqual params order

    @Trott
    Rock Hu authored and Trott committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    b54dd17 View commit details
    Browse the repository at this point in the history

  6. test: change to arrow functions in send-bad-arguments

    @annatangzhao @Trott
    annatangzhao authored and Trott committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    8c8e883 View commit details
    Browse the repository at this point in the history

  7. lib: remove an unused variable

    @chenyil @Trott
    chenyil authored and Trott committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    3743a72 View commit details
    Browse the repository at this point in the history

  8. test: fix argument order for assert.strictEqual

    @inklin @Trott
    inklin authored and Trott committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    a0e7710 View commit details
    Browse the repository at this point in the history

  9. tls: update try catch syntax 

    try catch syntax allows elimination of function arguments
so removed unused err argument
    @UNLRN @Trott
    UNLRN authored and Trott committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    d2acacd View commit details
    Browse the repository at this point in the history