Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: switch to internalBinding for cjs loader #23492

Closed
wants to merge 2 commits into from
+4 −3
Closed

lib: switch to internalBinding for cjs loader #23492

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9baf5e7
lib: switch to internalBinding for cjs loader
DrakiaXYZ Oct 12, 2018
60c58d3
Remove unneeded !! as getOptions returns a bool
DrakiaXYZ Oct 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove unneeded !! as getOptions returns a bool
@DrakiaXYZ
DrakiaXYZ committed Oct 12, 2018

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 59F3066AAFCA2735
Learn about vigilant mode
commit 60c58d3f222f5502999cec44de506dde34a3acc5
6 changes: 3 additions & 3 deletions lib/internal/modules/cjs/loader.js
View file
Original file line number Diff line number Diff line change
@@ -42,9 +42,9 @@ const {
stripShebang
} = require('internal/modules/cjs/helpers');
const options = internalBinding('options');
const preserveSymlinks = !!options.getOptions('--preserve-symlinks');
const preserveSymlinksMain = !!options.getOptions('--preserve-symlinks-main');
const experimentalModules = !!options.getOptions('--experimental-modules');
const preserveSymlinks = options.getOptions('--preserve-symlinks');
const preserveSymlinksMain = options.getOptions('--preserve-symlinks-main');
const experimentalModules = options.getOptions('--experimental-modules');

const {
ERR_INVALID_ARG_TYPE,