Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: switch to internalBinding for cjs loader #23492

Closed
wants to merge 2 commits into from
Closed

lib: switch to internalBinding for cjs loader #23492

wants to merge 2 commits into from

Conversation

DrakiaXYZ
Copy link
Contributor

Switch the cjs loader to use internalBinding instead of
process.binding for reading command line options.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@DrakiaXYZ
lib: switch to internalBinding for cjs loader
9baf5e7 
Switch the cjs loader to use internalBinding instead of
process.binding for reading command line options.
devsnek
devsnek reviewed Oct 12, 2018
View reviewed changes
lib/internal/modules/cjs/loader.js Outdated
const preserveSymlinksMain = !!process.binding('config').preserveSymlinksMain;
const experimentalModules = !!process.binding('config').experimentalModules;
const options = internalBinding('options');
const preserveSymlinks = !!options.getOptions('--preserve-symlinks');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's no need for the !! here, as options.getOptions already returns true/false

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the !! in a second commit. I wasn't sure whether I should or not, as they were there for the old code. Thanks!

@targos targos added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 12, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Oct 15, 2018
@DrakiaXYZ @BridgeAR
lib: switch to internalBinding for cjs loader
d9c0998 
Switch the cjs loader to use internalBinding instead of
process.binding for reading command line options.

PR-URL: nodejs#23492
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Oct 15, 2018
@DrakiaXYZ @BridgeAR
lib: switch to internalBinding for cjs loader
0399650 
Switch the cjs loader to use internalBinding instead of
process.binding for reading command line options.

PR-URL: nodejs#23492
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR
Copy link
Member

Landed in 0399650 🎉

@TheDgtl congratulations on your commit to Node.js!

@BridgeAR BridgeAR closed this Oct 15, 2018
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@DrakiaXYZ @jasnell
lib: switch to internalBinding for cjs loader
540c01a 
Switch the cjs loader to use internalBinding instead of
process.binding for reading command line options.

PR-URL: #23492
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
addaleax pushed a commit that referenced this pull request Oct 20, 2018
@DrakiaXYZ @addaleax
lib: switch to internalBinding for cjs loader
2736b8c 
Switch the cjs loader to use internalBinding instead of
process.binding for reading command line options.

PR-URL: #23492
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
@DrakiaXYZ @MylesBorins
lib: switch to internalBinding for cjs loader
c634698 
Switch the cjs loader to use internalBinding instead of
process.binding for reading command line options.

PR-URL: #23492
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@DrakiaXYZ @rvagg
lib: switch to internalBinding for cjs loader
3311d9e 
Switch the cjs loader to use internalBinding instead of
process.binding for reading command line options.

PR-URL: #23492
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@DrakiaXYZ @MylesBorins
lib: switch to internalBinding for cjs loader
33cf3b2 
Switch the cjs loader to use internalBinding instead of
process.binding for reading command line options.

PR-URL: #23492
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@devsnek devsnek devsnek approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@DrakiaXYZ @BridgeAR @jasnell @cjihrig @devsnek @gireeshpunathil @trivikr @targos