-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v8.x backport] deps: backport 804a693 from upstream V8 #22177
Commits on Aug 7, 2018
-
deps: cherry-pick 6989b3f6d7 from V8 upstream
Original commit message: Fix default Intl language tag handling With certain ICU data bundles (such as the Node.js "small-icu"), %GetDefaultICULocale() may return a more specific language tag (e.g. "en-US") than what's available (e.g. "en"). In those cases, consider the more specific language tag supported. This CL also resolves the following Node.js issue: nodejs#15223 Bug: v8:7024 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ifda0776b3418734d5caa8af4e50c17cda95add73 Reviewed-on: https://chromium-review.googlesource.com/668350 Commit-Queue: Daniel Ehrenberg <[email protected]> Reviewed-by: Daniel Ehrenberg <[email protected]> Cr-Commit-Position: refs/heads/master@{nodejs#52716} PR-URL: nodejs#20826 Fixes: nodejs#15223 Refs: v8/v8@6989b3f Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bb1e8a6 - Browse repository at this point
Copy the full SHA bb1e8a6View commit details -
deps: Upgrade node-inspect to 1.11.5
Removes the prompt to report a bug when trying to launch the debugger using a port that is already in use. Changeset generated via: ``` rm -rf deps/node-inspect node-inspect-* && \ curl -sSL "https://github.com/nodejs/node-inspect/archive/v1.11.5.tar.gz" | \ tar -xzvf - && mv node-inspect-* deps/node-inspect ``` PR-URL: nodejs#21055 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0c43ea4 - Browse repository at this point
Copy the full SHA 0c43ea4View commit details -
doc: add error check to fs example
Previously, the err passed to the callback of fs.open() was not checked. PR-URL: nodejs#18681 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d388282 - Browse repository at this point
Copy the full SHA d388282View commit details -
test: add useful info to error msg and refactor
Add useful info about process.domain to error meesages in the uncaughtException event listener and the beforeExit event listener. Refactor code such as using template literals, and also make sure uncaughtException listner is detached after firing once to avoid endless loop in case of exception throw in the beforeExit event listner. PR-URL: nodejs#18541 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0b2d35c - Browse repository at this point
Copy the full SHA 0b2d35cView commit details -
test: add crypto check to test-benchmark-tls
Currently when building --without-ssl a 'ERR_NO_CRYPTO' error is reported. This is not currently being picked up by the crypto-check lint rule as it does not actually require any crypto modules directly, but instead this is done by common/benchmark. PR-URL: nodejs#18724 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for edd8b2f - Browse repository at this point
Copy the full SHA edd8b2fView commit details -
test: add multiline repl input regression test
This commit adds a regression test for de848ac, which broke multiline input in the REPL. PR-URL: nodejs#18718 Refs: nodejs#17828 Refs: nodejs#18715 Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bc66d4e - Browse repository at this point
Copy the full SHA bc66d4eView commit details -
doc: update crypo Certficate class.
Update the dead link to <keygen> documentation. Add a link to mozilla developper documentation because W3C deleted the reference to this element. Add a note to inform <keygen> element is deprecated since HTML 5.2. PR-URL: nodejs#18721 Fixes: nodejs#18662 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b01e470 - Browse repository at this point
Copy the full SHA b01e470View commit details -
test: add lib path env when node_shared=true
When building the node with `--shared` option, the major output is the shared library. However, we still build a node executable which links to the shared lib. It's for testing purpose. When testing with the executable, some test cases move/copy the executable, change the relative path to the shared library and fail. Using lib path env would solve the issue. However, in macOS, need to change the install name for the shared library and use rpath in the executable. In AIX, `-brtl` linker option rebinds the symbols in the executable and addon modules could use them. Signed-off-by: Yihong Wang <[email protected]> PR-URL: nodejs#18626 Refs: nodejs#18535 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a66434f - Browse repository at this point
Copy the full SHA a66434fView commit details -
test: wrap countdown callback in common.mustCall
This adds a implicit common.mustCall to the callback provided to the countdown. PR-URL: nodejs#18506 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 92a90d1 - Browse repository at this point
Copy the full SHA 92a90d1View commit details -
doc: remove extra space in README.md
PR-URL: nodejs#18822 Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6a8c182 - Browse repository at this point
Copy the full SHA 6a8c182View commit details -
test: try to connect after server was closed
PR-URL: nodejs#18257 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7fbc6a4 - Browse repository at this point
Copy the full SHA 7fbc6a4View commit details -
test: reduce benchmark test run time
The `millions` argument was missing. PR-URL: nodejs#18787 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 06b6507 - Browse repository at this point
Copy the full SHA 06b6507View commit details -
test: make tls test more rigorous
* exit naturally, don't use process.exit() * ensure callbacks are actually called PR-URL: nodejs#18792 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 077fb0a - Browse repository at this point
Copy the full SHA 077fb0aView commit details -
test: refactor of test-tls-over-http-tunnel
PR-URL: nodejs#18784 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0ef0dbc - Browse repository at this point
Copy the full SHA 0ef0dbcView commit details -
test: refactor parallel/test-tls-addca
PR-URL: nodejs#18798 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8345f3c - Browse repository at this point
Copy the full SHA 8345f3cView commit details -
test,benchmark,doc: enable dot-notation rule
This enables the eslint dot-notation rule for all code instead of only in /lib. PR-URL: nodejs#18749 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4070782 - Browse repository at this point
Copy the full SHA 4070782View commit details -
doc: note that linting is required in releases.md
Refs: nodejs#18769 PR-URL: nodejs#18776 Refs: nodejs#18769 Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8651766 - Browse repository at this point
Copy the full SHA 8651766View commit details -
doc: activate
no-multiple-empty-lines
ruleThis enables the `no-multiple-empty-lines` eslint rule for the docs. PR-URL: nodejs#18747 Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b4fa857 - Browse repository at this point
Copy the full SHA b4fa857View commit details -
src: allow --perf-(basic-)?prof in NODE_OPTIONS
PR-URL: nodejs#17600 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bf1ca7e - Browse repository at this point
Copy the full SHA bf1ca7eView commit details -
crypto: allow passing null as IV unless required
Backport-PR-URL: nodejs#19347 PR-URL: nodejs#18644 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c1c6253 - Browse repository at this point
Copy the full SHA c1c6253View commit details -
async_hooks: rename PromiseWrap.parentId
Rename the `parentId` property on the PromiseWrap object to a `isChainedPromise` property. The former wasn't quite useful as it was always defined to be the same value as the trigger id available in the init hook. Instead rename the property to be closer to the information it communicates: whether the promise is a chained promise or not. PR-URL: nodejs#18633 Fixes: nodejs#18470 Reviewed-By: Andreas Madsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c3a96ba - Browse repository at this point
Copy the full SHA c3a96baView commit details -
fs: support as and as+ flags in stringToFlags()
PR-URL: nodejs#18801 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a2e4940 - Browse repository at this point
Copy the full SHA a2e4940View commit details -
doc: add missing metadata for fs.open
PR-URL: nodejs#19585 Refs: nodejs#18801 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5975c06 - Browse repository at this point
Copy the full SHA 5975c06View commit details -
tls: expose Finished messages in TLSSocket
Exposes SSL_get_finished and SSL_get_peer_finished routines in OpenSSL as tlsSocket.getFinished and tlsSocket.getPeerFinished, respectively. PR-URL: nodejs#19102 Fixes: nodejs#19055 Refs: XRPLF/rippled#2413 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bcaba81 - Browse repository at this point
Copy the full SHA bcaba81View commit details -
fs,net: emit 'ready' for fs streams and sockets
... in addition to the event names they currently use. Currently, various internal streams have different events that indicate that the underlying resource has successfully been established. This commit adds ready event for fs and net sockets to standardize on emitting ready for all of these streams. PR-URL: nodejs#19408 Fixes: nodejs#19304 Reviewed-By: Anna Henningsen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ae6e4bd - Browse repository at this point
Copy the full SHA ae6e4bdView commit details -
deps: backport 804a693 from upstream V8
Original commit message: [postmortem] add JS_ERROR_TYPE and context embedder index * JS_ERROR_TYPE is required for postmortem tools to inspect JSError objects (see nodejs/llnode#215 for a usage example) * The context embedder index is required for postmortem tools to access embedder data stored in the context (see nodejs/llnode#204 for a usage example) [email protected], [email protected] Change-Id: Ib7c7eb44f6ad327fc71a1d45f510c49377db7a25 Reviewed-on: https://chromium-review.googlesource.com/1138493 Reviewed-by: Benedikt Meurer <[email protected]> Commit-Queue: Benedikt Meurer <[email protected]> Cr-Commit-Position: refs/heads/master@{nodejs#54475} Refs: v8/v8@804a693 PR-URL: nodejs#21855 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yang Guo <[email protected]>
Matheus Marchini committedAug 7, 2018 Configuration menu - View commit details
-
Copy full SHA for d3cc97b - Browse repository at this point
Copy the full SHA d3cc97bView commit details