Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v8.x backport] deps: backport 804a693 from upstream V8 #22177

Closed
wants to merge 26 commits into from

Commits on Aug 7, 2018

  1. deps: cherry-pick 6989b3f6d7 from V8 upstream

    Original commit message:
      Fix default Intl language tag handling
    
      With certain ICU data bundles (such as the Node.js "small-icu"),
      %GetDefaultICULocale() may return a more specific language tag (e.g.
      "en-US") than what's available (e.g. "en"). In those cases, consider the
      more specific language tag supported.
    
      This CL also resolves the following Node.js issue:
         nodejs#15223
    
      Bug: v8:7024
      Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
      Change-Id: Ifda0776b3418734d5caa8af4e50c17cda95add73
      Reviewed-on: https://chromium-review.googlesource.com/668350
      Commit-Queue: Daniel Ehrenberg <[email protected]>
      Reviewed-by: Daniel Ehrenberg <[email protected]>
      Cr-Commit-Position: refs/heads/master@{nodejs#52716}
    
    PR-URL: nodejs#20826
    Fixes: nodejs#15223
    Refs: v8/v8@6989b3f
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Anatoli Papirovski <[email protected]>
    Reviewed-By: Ben Noordhuis <[email protected]>
    TimothyGu authored and MylesBorins committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    bb1e8a6 View commit details
    Browse the repository at this point in the history
  2. deps: Upgrade node-inspect to 1.11.5

    Removes the prompt to report a bug when trying to launch the
    debugger using a port that is already in use.
    
    Changeset generated via:
    
    ```
    rm -rf deps/node-inspect node-inspect-* && \
      curl -sSL "https://github.com/nodejs/node-inspect/archive/v1.11.5.tar.gz" | \
      tar -xzvf - && mv node-inspect-* deps/node-inspect
    ```
    
    PR-URL: nodejs#21055
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Ben Noordhuis <[email protected]>
    Jan Krems authored and MylesBorins committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    0c43ea4 View commit details
    Browse the repository at this point in the history
  3. doc: add error check to fs example

    Previously, the err passed to the callback of fs.open() was not checked.
    
    PR-URL: nodejs#18681
    Reviewed-By: Anatoli Papirovski <[email protected]>
    Reviewed-By: Vse Mozhet Byt <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    evanlucas authored and MylesBorins committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    d388282 View commit details
    Browse the repository at this point in the history
  4. test: add useful info to error msg and refactor

    Add useful info about process.domain to error meesages in the
    uncaughtException event listener and the beforeExit event listener.
    
    Refactor code such as using template literals, and also make sure
    uncaughtException listner is detached after firing once to avoid
    endless loop in case of exception throw in the beforeExit event
    listner.
    
    PR-URL: nodejs#18541
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    chinhuang007 authored and MylesBorins committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    0b2d35c View commit details
    Browse the repository at this point in the history
  5. test: add crypto check to test-benchmark-tls

    Currently when building --without-ssl a 'ERR_NO_CRYPTO' error is
    reported.
    
    This is not currently being picked up by the crypto-check lint rule as
    it does not actually require any crypto modules directly, but instead
    this is done by common/benchmark.
    
    PR-URL: nodejs#18724
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    danbev authored and MylesBorins committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    edd8b2f View commit details
    Browse the repository at this point in the history
  6. test: add multiline repl input regression test

    This commit adds a regression test for
    de848ac, which broke
    multiline input in the REPL.
    
    PR-URL: nodejs#18718
    Refs: nodejs#17828
    Refs: nodejs#18715
    Reviewed-By: Ruben Bridgewater <[email protected]>
    cjihrig authored and MylesBorins committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    bc66d4e View commit details
    Browse the repository at this point in the history
  7. doc: update crypo Certficate class.

    Update the dead link to <keygen> documentation.
    Add a link to mozilla developper documentation because
    W3C deleted the reference to this element.
    
    Add a note to inform <keygen> element is deprecated since HTML 5.2.
    
    PR-URL: nodejs#18721
    Fixes: nodejs#18662
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Vse Mozhet Byt <[email protected]>
    antoine-amara authored and MylesBorins committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    b01e470 View commit details
    Browse the repository at this point in the history
  8. test: add lib path env when node_shared=true

    When building the node with `--shared` option, the major output is the
    shared library. However, we still build a node executable which links
    to the shared lib. It's for testing purpose. When testing with the
    executable, some test cases move/copy the executable, change the
    relative path to the shared library and fail. Using lib path env would
    solve the issue. However, in macOS, need to change the install name for
    the shared library and use rpath in the executable. In AIX, `-brtl`
    linker option rebinds the symbols in the executable and addon modules
    could use them.
    
    Signed-off-by: Yihong Wang <[email protected]>
    
    PR-URL: nodejs#18626
    Refs: nodejs#18535
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    yhwang authored and MylesBorins committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    a66434f View commit details
    Browse the repository at this point in the history
  9. test: wrap countdown callback in common.mustCall

    This adds a implicit common.mustCall to the callback provided to
    the countdown.
    
    PR-URL: nodejs#18506
    Reviewed-By: Anatoli Papirovski <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Bamieh authored and MylesBorins committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    92a90d1 View commit details
    Browse the repository at this point in the history
  10. doc: remove extra space in README.md

    PR-URL: nodejs#18822
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Matheus Marchini authored and MylesBorins committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    6a8c182 View commit details
    Browse the repository at this point in the history
  11. test: try to connect after server was closed

    PR-URL: nodejs#18257
    Reviewed-By: Joyee Cheung <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Anatoli Papirovski <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Leko authored and MylesBorins committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    7fbc6a4 View commit details
    Browse the repository at this point in the history
  12. test: reduce benchmark test run time

    The `millions` argument was missing.
    
    PR-URL: nodejs#18787
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    juggernaut451 authored and MylesBorins committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    06b6507 View commit details
    Browse the repository at this point in the history
  13. test: make tls test more rigorous

    * exit naturally, don't use process.exit()
    * ensure callbacks are actually called
    
    PR-URL: nodejs#18792
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Matheus Marchini <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    bnoordhuis authored and MylesBorins committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    077fb0a View commit details
    Browse the repository at this point in the history
  14. test: refactor of test-tls-over-http-tunnel

    PR-URL: nodejs#18784
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Daniel Bevenius <[email protected]>
    juggernaut451 authored and MylesBorins committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    0ef0dbc View commit details
    Browse the repository at this point in the history
  15. test: refactor parallel/test-tls-addca

    PR-URL: nodejs#18798
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Matheus Marchini <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Daniel Bevenius <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    juggernaut451 authored and MylesBorins committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    8345f3c View commit details
    Browse the repository at this point in the history
  16. test,benchmark,doc: enable dot-notation rule

    This enables the eslint dot-notation rule for all code instead of
    only in /lib.
    
    PR-URL: nodejs#18749
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Matheus Marchini <[email protected]>
    BridgeAR authored and MylesBorins committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    4070782 View commit details
    Browse the repository at this point in the history
  17. doc: note that linting is required in releases.md

    Refs: nodejs#18769
    
    PR-URL: nodejs#18776
    Refs: nodejs#18769
    Reviewed-By: Matheus Marchini <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    gibfahn authored and MylesBorins committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    8651766 View commit details
    Browse the repository at this point in the history
  18. doc: activate no-multiple-empty-lines rule

    This enables the `no-multiple-empty-lines` eslint rule for the docs.
    
    PR-URL: nodejs#18747
    Reviewed-By: Weijia Wang <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Matheus Marchini <[email protected]>
    BridgeAR authored and MylesBorins committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    b4fa857 View commit details
    Browse the repository at this point in the history
  19. src: allow --perf-(basic-)?prof in NODE_OPTIONS

    PR-URL: nodejs#17600
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Joyee Cheung <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Leko authored and MylesBorins committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    bf1ca7e View commit details
    Browse the repository at this point in the history
  20. crypto: allow passing null as IV unless required

    Backport-PR-URL: nodejs#19347
    PR-URL: nodejs#18644
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    tniessen authored and MylesBorins committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    c1c6253 View commit details
    Browse the repository at this point in the history
  21. async_hooks: rename PromiseWrap.parentId

    Rename the `parentId` property on the PromiseWrap object to a
    `isChainedPromise` property. The former wasn't quite useful as it was
    always defined to be the same value as the trigger id available in the
    init hook. Instead rename the property to be closer to the information
    it communicates: whether the promise is a chained promise or not.
    
    PR-URL: nodejs#18633
    Fixes: nodejs#18470
    Reviewed-By: Andreas Madsen <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
    ofrobots authored and MylesBorins committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    c3a96ba View commit details
    Browse the repository at this point in the history
  22. fs: support as and as+ flags in stringToFlags()

    PR-URL: nodejs#18801
    Reviewed-By: Joyee Cheung <[email protected]>
    Reviewed-By: Matheus Marchini <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    SirR4T authored and MylesBorins committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    a2e4940 View commit details
    Browse the repository at this point in the history
  23. doc: add missing metadata for fs.open

    PR-URL: nodejs#19585
    Refs: nodejs#18801
    Reviewed-By: Vse Mozhet Byt <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    tniessen authored and MylesBorins committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    5975c06 View commit details
    Browse the repository at this point in the history
  24. tls: expose Finished messages in TLSSocket

    Exposes SSL_get_finished and SSL_get_peer_finished routines in OpenSSL
    as tlsSocket.getFinished and tlsSocket.getPeerFinished, respectively.
    
    PR-URL: nodejs#19102
    Fixes: nodejs#19055
    Refs: XRPLF/rippled#2413
    Reviewed-By: Fedor Indutny <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    codedot authored and MylesBorins committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    bcaba81 View commit details
    Browse the repository at this point in the history
  25. fs,net: emit 'ready' for fs streams and sockets

    ... in addition to the event names they currently use.
    
    Currently, various internal streams have different events that
    indicate that the underlying resource has successfully been
    established. This commit adds ready event for fs and net
    sockets to standardize on emitting ready for all of these streams.
    
    PR-URL: nodejs#19408
    Fixes: nodejs#19304
    Reviewed-By: Anna Henningsen <[email protected]>
    sameer-coder authored and MylesBorins committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    ae6e4bd View commit details
    Browse the repository at this point in the history
  26. deps: backport 804a693 from upstream V8

    Original commit message:
    
        [postmortem] add JS_ERROR_TYPE and context embedder index
    
          * JS_ERROR_TYPE is required for postmortem tools to inspect
            JSError objects (see nodejs/llnode#215
            for a usage example)
          * The context embedder index is required for postmortem tools to
            access embedder data stored in the context (see
            nodejs/llnode#204 for a usage example)
    
        [email protected], [email protected]
    
        Change-Id: Ib7c7eb44f6ad327fc71a1d45f510c49377db7a25
        Reviewed-on: https://chromium-review.googlesource.com/1138493
        Reviewed-by: Benedikt Meurer <[email protected]>
        Commit-Queue: Benedikt Meurer <[email protected]>
        Cr-Commit-Position: refs/heads/master@{nodejs#54475}
    
    Refs: v8/v8@804a693
    
    PR-URL: nodejs#21855
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Gus Caplan <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Yang Guo <[email protected]>
    Matheus Marchini committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    d3cc97b View commit details
    Browse the repository at this point in the history