Revert "repl: refactor tests to not rely on timing" #18715
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit de848ac. The commit broke multiline repl.
cjihrig
approved these changes
Feb 11, 2018
2 tasks
BridgeAR
added
the
author ready
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Feb 12, 2018
This reverts commit de848ac. The commit broke multiline repl. PR-URL: nodejs#18715 Refs: nodejs#17828 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Landed in 1fc373b |
cjihrig
added a commit
to cjihrig/node
that referenced
this pull request
Feb 14, 2018
This commit adds a regression test for de848ac, which broke multiline input in the REPL. PR-URL: nodejs#18718 Refs: nodejs#17828 Refs: nodejs#18715 Reviewed-By: Ruben Bridgewater <[email protected]>
|
Original didn't land in a release, setting as don't land /cc @jasnell re: 10 |
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
This commit adds a regression test for de848ac, which broke multiline input in the REPL. PR-URL: #18718 Refs: #17828 Refs: #18715 Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
This commit adds a regression test for de848ac, which broke multiline input in the REPL. PR-URL: #18718 Refs: #17828 Refs: #18715 Reviewed-By: Ruben Bridgewater <[email protected]>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
This reverts commit de848ac. The commit broke multiline repl. PR-URL: nodejs#18715 Refs: nodejs#17828 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
This commit adds a regression test for de848ac, which broke multiline input in the REPL. PR-URL: nodejs#18718 Refs: nodejs#17828 Refs: nodejs#18715 Reviewed-By: Ruben Bridgewater <[email protected]>
targos
removed
the
author ready
MylesBorins
pushed a commit
that referenced
this pull request
Aug 7, 2018
This commit adds a regression test for de848ac, which broke multiline input in the REPL. PR-URL: #18718 Refs: #17828 Refs: #18715 Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 7, 2018
This commit adds a regression test for de848ac, which broke multiline input in the REPL. PR-URL: #18718 Refs: #17828 Refs: #18715 Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 9, 2018
This commit adds a regression test for de848ac, which broke multiline input in the REPL. PR-URL: #18718 Refs: #17828 Refs: #18715 Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 16, 2018
This commit adds a regression test for de848ac, which broke multiline input in the REPL. PR-URL: #18718 Refs: #17828 Refs: #18715 Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit de848ac.
The commit broke multiline repl.
It can easily be checked by trying to write something after entering
{.Refs: #17828
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
repl