timers: add an internal [@@refresh()] function #18065
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fishrock123
added
timers
nodejs-github-bot
added
the
lib / src
Fishrock123
added
net
jasnell
reviewed
Jan 9, 2018
lib/internal/http2/core.js
Outdated
| @@ -908,7 +907,7 @@ class Http2Session extends EventEmitter { | |||
| [kUpdateTimer]() { | |||
| if (this.destroyed) | |||
| return; | |||
| if (this[kTimeout]) _unrefActive(this[kTimeout]); | |||
| if (this[kTimeout]) this[kTimeout][refresh_fn_symbol](true); | |||
There was a problem hiding this comment.
whoops, was from a previous API version
Fishrock123
force-pushed
the
timers-internal-refresh
branch
4 times, most recently
from
11f4c34
to
8c5aa92
Compare
|
@apapirovski @zhangzifa Any thoughts? |
apapirovski
approved these changes
Jan 19, 2018
Fishrock123
force-pushed
the
timers-internal-refresh
branch
from
8c5aa92
to
a08570c
Compare
|
Updated, new CI: https://ci.nodejs.org/job/node-test-pull-request/12755/ @apapirovski better now? |
apapirovski
approved these changes
Jan 26, 2018
Just cleanup so the file makes more future sense. PR-URL: nodejs#18065 Reviewed-By: Anatoli Papirovski <[email protected]>
Hidden via a symbol because I'm unsure exactly what the API should look like in the end. Removes the need to use _unrefActive for efficiently refreshing timeouts. It still uses it under the hood but that could be replaced with insert() directly if it were in the same file. PR-URL: nodejs#18065 Reviewed-By: Anatoli Papirovski <[email protected]>
Fishrock123
force-pushed
the
timers-internal-refresh
branch
from
a08570c
to
acb5ad3
Compare
Fishrock123
added a commit
that referenced
this pull request
Jan 26, 2018
Just cleanup so the file makes more future sense. PR-URL: #18065 Reviewed-By: Anatoli Papirovski <[email protected]>
Fishrock123
added a commit
that referenced
this pull request
Jan 26, 2018
Hidden via a symbol because I'm unsure exactly what the API should look like in the end. Removes the need to use _unrefActive for efficiently refreshing timeouts. It still uses it under the hood but that could be replaced with insert() directly if it were in the same file. PR-URL: #18065 Reviewed-By: Anatoli Papirovski <[email protected]>
|
Thanks, landed in a5a8118...bb5575a |
|
This does not land cleanly on v9.x, should we backport? |
3 tasks
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Just cleanup so the file makes more future sense. PR-URL: nodejs#18065 Reviewed-By: Anatoli Papirovski <[email protected]>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Hidden via a symbol because I'm unsure exactly what the API should look like in the end. Removes the need to use _unrefActive for efficiently refreshing timeouts. It still uses it under the hood but that could be replaced with insert() directly if it were in the same file. PR-URL: nodejs#18065 Reviewed-By: Anatoli Papirovski <[email protected]>
|
@Fishrock123 should this be backported to |
|
@codebytere It’d be nice to backport — do you know if it depends on other commits of mine, or only the large timers refactor? I’ll try to get a backport PR up soon... |
|
@Fishrock123 my cursory inspection tells me the two timers commits need to be backported in concert but beyond that i think you're good! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hidden via a symbol because I'm unsure exactly what the API should look like in the end.
Removes the need to use
_unrefActive()for efficiently refreshing timeouts. It still uses it under the hood but that could be replaced withinsert()directly if it were in the same file.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
timers