Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timers: add an internal [@@refresh()] function #18065

Closed
wants to merge 2 commits into from
Closed

timers: add an internal [@@refresh()] function #18065

wants to merge 2 commits into from

Commits on Jan 26, 2018

  1. timers: reposition getTimers definition internally 

    Just cleanup so the file makes more future sense.

PR-URL: nodejs#18065
Reviewed-By: Anatoli Papirovski <[email protected]>
    @Fishrock123
    Fishrock123 committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    587c6a5 View commit details
    Browse the repository at this point in the history

  2. timers: add internal [@@ refresh()] function 

    Hidden via a symbol because I'm unsure exactly what the API should look
like in the end.

Removes the need to use _unrefActive for efficiently refreshing
timeouts.
It still uses it under the hood but that could be replaced with
insert() directly if it were in the same file.

PR-URL: nodejs#18065
Reviewed-By: Anatoli Papirovski <[email protected]>
    @Fishrock123
    Fishrock123 committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    acb5ad3 View commit details
    Browse the repository at this point in the history