Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timers: fix unref() memory leak #1152

Closed
wants to merge 2 commits into from
Closed

timers: fix unref() memory leak #1152

wants to merge 2 commits into from

Commits on Apr 2, 2015

  1. timers: fix unref() memory leak 

    The destructor isn't being called for timers that have been unref'd.

Fixes: nodejs/node-v0.x-archive#8364
    @trevnorris @Fishrock123
    trevnorris authored and Fishrock123 committed Apr 2, 2015
    Configuration menu
    Copy the full SHA
    47335ce View commit details
    Browse the repository at this point in the history

  2. timers: don't close interval timers when unrefd 

    This change fixes a regression introduced by commit
0d05123, which contained a typo that
would cause every unrefd interval to fire only once.

Fixes: nodejs/node-v0.x-archive#8900
Reviewed-By: Timothy J Fontaine <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-by: Trevor Norris <[email protected]>
    @Fishrock123
    Julien Gilli authored and Fishrock123 committed Apr 2, 2015
    Configuration menu
    Copy the full SHA
    ba676bf View commit details
    Browse the repository at this point in the history