timers: fix unref() memory leak

The destructor isn't being called for timers that have been unref'd. Fixes: nodejs/node-v0.x-archive#8364 Signed-off-by: Trevor Norris <[email protected]>
Fishrock123 · Nov 26, 2014 · 0d05123 · 0d05123
1 parent 3a08b7c
commit 0d05123
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/icu_config.gypi b/icu_config.gypi
@@ -0,0 +1,2 @@
+# Do not edit. Generated by the configure script.
+{ 'variables': { }}
diff --git a/lib/timers.js b/lib/timers.js
@@ -290,6 +290,14 @@ var Timeout = function(after) {
   this._repeat = false;
 };
 
+
+function unrefdHandle() {
+  this.owner._onTimeout();
+  if (!this.owner.repeat)
+    this.owner.close();
+}
+
+
 Timeout.prototype.unref = function() {
   if (!this._handle) {
 
@@ -303,7 +311,8 @@ Timeout.prototype.unref = function() {
     if (delay < 0) delay = 0;
     exports.unenroll(this);
     this._handle = new Timer();
-    this._handle.ontimeout = this._onTimeout;
+    this._handle.owner = this;
+    this._handle.ontimeout = unrefdHandle;
     this._handle.start(delay, 0);
     this._handle.domain = this.domain;
     this._handle.unref();