src: manage MakeContext() pointer with unique_ptr

PR-URL: #28616 Refs: #28452 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
nodejs · Jul 20, 2019 · 3c418d9 · 3c418d9
1 parent 22daf95
commit 3c418d9
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/src/node_contextify.cc b/src/node_contextify.cc
@@ -255,24 +255,21 @@ void ContextifyContext::MakeContext(const FunctionCallbackInfo<Value>& args) {
   options.allow_code_gen_wasm = args[4].As<Boolean>();
 
   TryCatchScope try_catch(env);
-  ContextifyContext* context = new ContextifyContext(env, sandbox, options);
+  auto context_ptr = std::make_unique<ContextifyContext>(env, sandbox, options);
 
   if (try_catch.HasCaught()) {
     if (!try_catch.HasTerminated())
       try_catch.ReThrow();
-    delete context;
     return;
   }
 
-  if (context->context().IsEmpty()) {
-    delete context;
+  if (context_ptr->context().IsEmpty())
     return;
-  }
 
   sandbox->SetPrivate(
       env->context(),
       env->contextify_context_private_symbol(),
-      External::New(env->isolate(), context));
+      External::New(env->isolate(), context_ptr.release()));
 }