Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: manage MakeContext() pointer with unique_ptr #28616

Merged
merged 1 commit into from
Jul 12, 2019
Merged

src: manage MakeContext() pointer with unique_ptr #28616

merged 1 commit into from
Jul 12, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jul 9, 2019

Refs: #28452

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. vm Issues and PRs related to the vm subsystem. labels Jul 9, 2019
addaleax
addaleax approved these changes Jul 9, 2019
View reviewed changes
src/node_contextify.cc Outdated Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24363/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 10, 2019 •
edited by cjihrig
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/24364/

EDIT(cjihrig): CI was green.

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 11, 2019
@cjihrig
src: manage MakeContext() pointer with unique_ptr
641d57f 
PR-URL: nodejs#28616
Refs: nodejs#28452
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@cjihrig cjihrig merged commit 641d57f into nodejs:master Jul 12, 2019
@cjihrig cjihrig deleted the unique-ptr branch July 12, 2019 13:10
targos pushed a commit that referenced this pull request Jul 20, 2019
@cjihrig @targos
src: manage MakeContext() pointer with unique_ptr
3c418d9 
PR-URL: #28616
Refs: #28452
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
This was referenced Jul 23, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cjihrig @nodejs-github-bot @Trott @addaleax @BridgeAR