Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Added AsyncProgressWorker to readme #588

Merged
merged 1 commit into from
Nov 13, 2019
Merged

doc: Added AsyncProgressWorker to readme #588

merged 1 commit into from
Nov 13, 2019

Conversation

NickNaso
Copy link
Member

@NickNaso NickNaso commented Nov 5, 2019

Reference the documentation for Napi::AsyncProgressWorker int the README

@NickNaso NickNaso mentioned this pull request Nov 5, 2019
Closed
15 tasks
KevinEady
KevinEady approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@KevinEady KevinEady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson
mhdawson approved these changes Nov 6, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickNaso NickNaso merged commit 24d75dd into nodejs:master Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@KevinEady KevinEady KevinEady approved these changes

@legendecas legendecas legendecas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NickNaso @legendecas @KevinEady @mhdawson