Next release 2.0.0

[NickNaso]

Hi everyone,
it's my intention create a new release. The last release is 1.7.1 and was deployed the 24rd July. Now we have some new APIs and important fixes to release. Here I report what we need to create this new release:

• Add Env() to AsyncContext - Merge PR Add Env() to AsyncContext. #568
• scopes: make failure of closing scopes fatal - Merge PR scopes: make failure of closing scopes fatal #566
• scope: disallow copying scopes to prevent double close of scopes - Merge PR scope: disallow copying scopes to prevent double close of scopes #565
• tsfn: Add wrappers for Ref and Unref - Merge PR tsfn: Add wrappers for Ref and Unref #561 (We need to merge PR tsfn: Implement copy constructor #546 before)
• Update the CMake.js doc to current best practices - Merge PR Update the CMake.js doc to current best practices #558
• doc: fix return type of ArrayBuffer::Data - Merge PR doc: fix return type of ArrayBuffer::Data #552
• tsfn: Implement copy constructor - Merge PR tsfn: Implement copy constructor #546 (We need to merge this before the tsfn: Add wrappers for Ref and Unref #561)
• Update Package JSON formatting Update the formatting so that we use the same format
  as it will be in once published.
• doc: Added AsyncProgressWorker to readme - Merge PR doc: Added AsyncProgressWorker to readme #588
• Fix example code in doc/class_property_descriptor - Merge PR Fix example code in doc/class_property_descriptor #587

Nice to have:

• AsyncProgressWorker - End work on PR Implement AsyncProgressWorker #529 and merge it.
• implement Object::AddFinalizer - End work on PR implement Object::AddFinalizer #551 and merge it.
• NAPI_EXPERIMENTAL mixed with various Node.js Major Version - End work on PR test: conditional test experimental features with NODE_MAJOR_VERSION #545 and merge it.
• fix ThreadSafeFunction::[Non]BlockingCall with pre-constructed napi_tsfn: Review and merge PR tsfn: support direct calls to underlying napi_tsfn #580
• add error handling to ThreadSafeFunction::GetContext: merge PR tsfn: add error checking on GetContext #583 . See tsfn: add error checking on GetContext #583 (comment) regarding semver-major release discussion

To discuss:

• - build: remove Node.js 6 from and add Node.js 13 to travis - Merge PR build: remove Node.js 6 from and add Node.js 13 to travis #573 deferred until 3.0.0

If anyone have some other things that needs to be done please add them in the list above.

EDIT 2019-10-29T19:10:16.385Z KevinEady: added #580 to "Nice to Have"
EDIT 2019-11-15T21:50:07.887Z KevinEady: added #583 to "Nice to Have"

[KevinEady]

Hi @NickNaso ,

I am currently working on a PR to address #556 (comment) like we discussed yesterday. I am waiting on #546 copy ctor before pushing it though. I think this is a good addition for 2.0.0 as well. I will add it to the list once I create a PR.

[legendecas]

#545 introduced a breaking change on the usage of the definition of NAPI_EXPERIMENTAL, it would be nice to land such a change on the next semver major version.

[NickNaso]

#545 introduced a breaking change on the usage of the definition of NAPI_EXPERIMENTAL, it would be nice to land such a change on the next semver major version.

@legendecas I added #545 to the list.

[KevinEady]

If this is a major version release, can we get rid of https://github.com/nodejs/node-addon-api/blob/master/napi-inl.deprecated.h ...?

[gabrielschulhof]

@KevinEady good point!

[NickNaso]

@KevinEady @gabrielschulhof could we remove the file without consequences? Is it right?

[gabrielschulhof]

@NickNaso there were also some conditionally defined sections that needed removing.

#572

[NickNaso]

@NickNaso there were also some conditionally defined sections that needed removing.

#572

Added to the list with #573 .

[mhdawson]

Not sure we want to do all: remove deprecated stuff but keep infra - Merge PR #572. While technically we can because its a SemVer major, we decided to do a major only because of changes we believe will have not effect on existing users. My preference would to avoid trully breaking changes.

[gabrielschulhof]

I'm OK with deferring the removal of the deprecated stuff. I've struck out the PR from the checklist.

[legendecas]

Just a thought: maybe we could utilize labels and GitHub milestone/project to track the releasing process. :P

[arielweinberger]

Can't wait for @legendecas' pull request bringing AsyncProgressWorker to node-addon-api! Thank you everybody!

[ghost]

Really excited about this new release (in particular with "tsfn: Implement copy constructor" which is a key feature that really makes a diff). I just hope the orginal scope is not increased too much so it gets delayed.

[mhdawson]

@NickNaso I think we are pretty much ready to make the new release.

[NickNaso]

@mhdawson I will wait until tomorrow just in case someone want add other things in the release.

[NickNaso]

Hi everyone I'm starting to create and publish the new release ...

[NickNaso]

Hi @gabrielschulhof @mhdawson,
I prepared all to publish the new release but we have problems on Node.js version 11 https://ci.nodejs.org/view/x%20-%20Abi%20stable%20module%20API/job/node-test-node-addon-api-new/1067/. I think that I can proceed to publish on npm. Is it ok for you?

[gabrielschulhof]

@NickNaso it looks like the CI is having trouble running Node.js v11.

[mhdawson]

@NickNaso at this point 11 is long out of service. The failures also look to me like issues with the configuration of the job (versus anything in the tests) that I probably only fixed up for 12 and later.

From my perspective those failures are 11 are not a concern.

[mhdawson]

The one on 13 was also likely a machine issue but started a new one for 13 to be sure.
https://ci.nodejs.org/view/x%20-%20Abi%20stable%20module%20API/job/node-test-node-addon-api-new/1076/

[NickNaso]

Hi @mhdawson,
now we have failures for all Node.js version on AIX, but I think that is an infrastructure problem:

Could someone help o solve this problem?

[NickNaso]

The CI is green now and I will proceed to publish the new release on npm.
Sorry it's not true I missed test on Node.js version 8 that are failing on AIX.

[mhdawson]

Those might still be machine issues, but the problem is that the other machines are off line so we'll need to get that figured out @sam-github

[NickNaso]

The CI now is green:

• Node.js v8 ✓
• Node.jsv10 ✓
• Node.js v12 ✓
• Node.js v13 ✓
• Node.j v14 (master) ✓

I'm going to complete the work to publish the release.

[NickNaso]

I'm closing the issue because the new release has been published.