Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to yarn 0.24.4 #400

Merged
merged 1 commit into from
May 13, 2017
Merged

Upgrade to yarn 0.24.4 #400

merged 1 commit into from
May 13, 2017

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented May 12, 2017

Should close #381 as well

@pesho
Copy link
Contributor

pesho commented May 12, 2017

Thanks, but I think Yarn should be upgraded together with new Node.js releases, as proposed in #393. Therefore 👎

@SimenB
Copy link
Member Author

SimenB commented May 12, 2017

This version fixes the bug in #346, though. Although I think it makes sense to do #393 after this 😄

@razor-x
Copy link
Contributor

razor-x commented May 12, 2017

In my opinion the node-gyp regression is serious and should not remain unpatched: we need to address it either by merging this or #346.

@pesho
Copy link
Contributor

pesho commented May 12, 2017

This version fixes the bug in #346, though. Although I think it makes sense to do #393 after this

Ok, this could be justified in order to get to a stable working state before becoming more conservative with updates. If the other @nodejs/docker members agree, let's merge this.

In my opinion the node-gyp regression is serious should not remain unpatched: we need address it either by merging this or #346.

Merging this would be the better option.

@chorrell
Copy link
Contributor

I tend to agree. We can be stricter about updating yarn after this lands.

@Starefossen
Copy link
Member

Starefossen commented May 13, 2017 via email

pesho

This comment was marked as off-topic.

@pesho pesho merged commit e099100 into nodejs:master May 13, 2017
@pesho
Copy link
Contributor

pesho commented May 13, 2017

Merged. Working on Docker Hub PR.

@pesho
Copy link
Contributor

pesho commented May 13, 2017

Docker Hub PR: docker-library/official-images#2950

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants