Add global node-gyp for yarn

[teohhanhui]

Fixes #346

See yarnpkg/yarn#2266

[Daniel15]

I feel like the proper fix is for packages to include node-gyp in their dependencies if they need it, rather than relying on it to be installed globally. This looks good to me though.

[teohhanhui]

@Daniel15 Isn't yarn intended as a drop-in replacement for npm? Then it's compulsory for node-gyp to be available out of the box: https://github.com/nodejs/node-gyp/wiki/Updating-npm's-bundled-node-gyp

npm bundles its own, internal, copy of node-gyp. This internal copy is independent of any globally installed copy of node-gyp that you may have installed via npm install -g node-gyp.

This means that while node-gyp doesn't get installed into your $PATH by default, npm still keeps its own copy to invoke when you attempt to npm install a native addon.

[Daniel15]

Yes, this should be fixed in the next Yarn release. For now I think it's totally fine to yarn global add it.

I still think packages that depend on node-gyp should make that explicit rather than having the implicit dependency.

[teohhanhui]

While you are still figuring out yarnpkg/yarn#3114, I think we should unbreak the Docker image.

[SimenB]

I agree on unbreaking the image, but it's fixed in yarn now, just need to wait on a release. Hopefully really soon 😄 yarnpkg/yarn#3240

[Daniel15]

It should be fine if you specify it as a dependency - both npm and Yarn add the ./node_modules/.bin directory to the process' PATH. Sent from my phone.

…

On Apr 26, 2017 3:01 AM, "Vlad Wing" ***@***.***> wrote: Even if a package would add node-gyp as their dependency, yarn would still have trouble finding the executable node-gyp in the $PATH. The error is something like this: ```sh: node-gyp: not found```` — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#381 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFnHW0pRL_Mibyxxkn1Ni3C5mI65n18ks5rzxXqgaJpZM4M8RkN> .

[vladwing]

@Daniel15: I tested that with the alpine tag, and it doesn't work.

Dockerfile:

FROM node:7.7.4-alpine
COPY package.json /srv/application/
RUN apk add --no-cache --virtual .build-deps \
        binutils-gold \
        findutils \
        curl \
        g++ \
        gcc \
        make \
        python && apk add --no-cache postgresql-dev \
&& cd /srv/application \
&& yarn install \
&& apk del .build-deps

package.json:

{
  "name": "test-yarn",
  "version": "1.0.0",
  "main": "index.js",
  "license": "MIT",
  "dependencies": {
    "libpq": "^1.8.7",
    "node-gyp": "^3.6.0"
  }
}

Command:

docker build .

Error:

error /srv/application/node_modules/libpq: Command failed.
Exit code: 127
Command: sh
Arguments: -c node-gyp rebuild
Directory: /srv/application/node_modules/libpq
Output:
sh: node-gyp: not found

Adding a yarn global add node-gyp before yarn install solves the problem.

PS. I tested with other versions of node:alpine as well, but I want to keep the version locked for this bug report.

[Daniel15]

@vladwing - The issue is that libpq doesn't specify node-gyp in its dependencies.

[razor-x]

@teohhanhui I am eager for this fix to be included in images that will not get the version of yarn with this fix. Is there any reason this PR is stalled? Anything I can help with to get it moving along?

[chorrell]

So if we add node-gyp to the images we won't be able to remove it going forward unless we want to deal with more breakage.

Has there been discussion on an official yarn image? Having and image tagged to a given yarn version would certainly help here.

[Daniel15]

So if we add node-gyp to the images we won't be able to remove it going forward unless we want to deal with more breakage.

The images should already have node-gyp given npm comes bundled with a version of it. Adding npm's version to the PATH would also solve the problem.

Upcoming Yarn releases have fixed this issue by using npm's version of node-gyp if available.