Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add back BATS for testing images #1588

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Add back BATS for testing images #1588

wants to merge 2 commits into from
+43 −21

Commits on Oct 23, 2021

  1. feat: Add back BATS for testing images 

    BATS was initially added to this repository in nodejs#802, but was then
removed in nodejs#1339. This adds it back, and hooks it up to Github Actions.

This also fixes nodejs#1583, which happened due to a bug in the "Build image"
step: the build context was set to the root project directory, which
meant the `COPY docker-entrypoint.sh /usr/local/bin/` instruction was
copying the base `docker-entrypoint.sh` file into the Docker image
instead of the one in the variant directory. Changing the context to the
variant directory solves that.
    @MasonM
    MasonM committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    f8853c4 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2022

  1. Remove submodule and use npx instead

    @MasonM
    MasonM committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    352a3b1 View commit details
    Browse the repository at this point in the history