ci: use single dynamic build-test action #1339
Conversation
There was a problem hiding this comment.
This would probably also drop the https://github.com/nodejs/docker-node/blob/master/.github/workflows/dockerfiles.yml
and -c part of the update.sh file
That makes sense with dropping https://github.com/nodejs/docker-node/blob/master/.github/workflows/dockerfiles.yml. In fact, that file currently calls It doesn't look like there is a |
Right, I forgot the letter I ended up changing it to 😆 |
ttshivers
force-pushed
the
single_test_action
branch
from
a20aeee
to
0acdcd7
Compare
ttshivers
force-pushed
the
single_test_action
branch
from
0acdcd7
to
d303c17
Compare
|
One question I have is whether to keep around test-build.sh and test-image.bats since the GitHub test action won't use them anymore. |
I don't feel very strongly about keeping them, but I think some people liked them, so I'll see who chimes in |
There was a problem hiding this comment.
One question I have is whether to keep around test-build.sh and test-image.bats since the GitHub test action won't use them anymore.
I don't feel very strongly about keeping them, but I think some people liked them, so I'll see who chimes in
I wanted to keep them as a way to run a test on the image from the outside, rather than on the inside during build. However, the tests now do docker run so I'm personally happy to remove them
ttshivers
force-pushed
the
single_test_action
branch
2 times, most recently
from
6c8543e
to
aa615be
Compare
ttshivers
force-pushed
the
single_test_action
branch
from
aa615be
to
23ea55a
Compare
Just delete those and we can merge? 🙂 |
ttshivers
force-pushed
the
single_test_action
branch
from
e98c222
to
00fd0ff
Compare
Deleted those files |
|
Squash the commits? At least the |
ttshivers
force-pushed
the
single_test_action
branch
2 times, most recently
from
02eeb6c
to
92d7b18
Compare
|
The errors seem to be due to the flaky gpg servers. Should a time limit be put on tests to prevent it hanging from 6 hours (default max job time) if it fails? |
|
As long as we don't build node it should just be a few minutes. Probably a good idea to lower the limit, yeah |
|
I would thing 30minutes to 1 hour like the old Travis setup would be fine |
Add a GitHub action that dynamically generates the matrix of Dockerfiles to test based on what files have changed. This avoids having to have generated workflows for each version x variant combo. It looks for any changed Dockerfiles, or docker-entrypoint.sh. If any of the testing files are changed, it will test all Dockerfiles
ttshivers
force-pushed
the
single_test_action
branch
from
92d7b18
to
ee169b2
Compare
|
Added a 60 minute timeout for each matrix entry. |
BATS was initially added to this repository in nodejs#802, but was then removed in nodejs#1339. This adds it back, and hooks it up to Github Actions.
BATS was initially added to this repository in nodejs#802, but was then removed in nodejs#1339. This adds it back, and hooks it up to Github Actions. This also fixes nodejs#1583, which happened due to a bug in the "Build image" step: the build context was set to the root project directory, which meant the `COPY docker-entrypoint.sh /usr/local/bin/` instruction was copying the base `docker-entrypoint.sh` file into the Docker image instead of the one in the variant directory. Changing the context to the variant directory solves that.
Add a GitHub action that dynamically generates the matrix of Dockerfiles to test based on what files have changed. This avoids having to have generated workflows for each version x variant combo.
It looks for any changed
Dockerfiles, ordocker-entrypoint.sh. If any of the testing files are changed, it will test allDockerfiles