Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplementation of the chart node using angular-chart.js #95

Merged
merged 4 commits into from
Nov 9, 2016

Conversation

DanCunnington
Copy link
Contributor

@DanCunnington DanCunnington commented Nov 8, 2016

Fix for #38

Summary

Known Issues

  • Charts render incorrectly when data points fall outside a specified range. Issue raised against Chart.js and failing test case created outside of Node-RED.
  • The last x Axis label can sometimes overlap. Outstanding PR on Chart.js to fix this issue.
  • Colours are manually specified - this may change when the theme chooser is implemented.

Note. This is a revised version of #89 to account for limiting the number of points as discussed in #38. This PR is ready for review.

@dceejay dceejay merged commit e685c39 into node-red:newchart Nov 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants