-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This fixes #2599 #2600
This fixes #2599 #2600
Conversation
I feel like this might be risky. hence the failing tests. I'm not sure the right way to handle this is to always remove the 2nd last tick. I can think of scenarios where this would lead to a large gap |
Yeah, I had the same concerns, but I didn't found a case where this would actually lead to a really large gap. |
Okay, I see... |
@haschu I was actually thinking about something like |
So, If you also consider an option like that, I'd like to come up with a solution very soon, since I need a workaround for project. Could you give a tiny example of what you were thinking exactly? There aren't any enum options so far, so we would need a global constants object, like:
Wouldn't a "normal" object be more consistent to the other options?: lastTick: {
showAlways: false,
anotherOption: true,
} |
@haschu I was thinking something like the enum you suggested. I'll let other chime in and see what they prefer. @zachpanz88 @tannerlinsley @derekperkins @simonbrunel |
Okay. |
Can you please rebase and squash? |
Also, could you please fix the conflicts that have to be resolved? |
Sure! I try to fix everything over the week. |
This would be great. Nice work!
|
@haschu this change would be amazing... any chance you are going to finish this or should i try? |
Oh sorry, I totally forgot that issue. I'm going to fix it as soon as I got some time :-). |
Still a problem :( |
Tried to hide the next to the last tick with the following config:
It kinda fixed the overlapping of the last tick, but then I resized the chart back and forth and noticed other ticks get overlapped too by some 10 pixels :( |
so what I did was change my time scale to linear scale, which works coz all my data has an equal time step, and provided a custom renderer for ticks with fixed format. no more overlaps. |
Hi, any movement? It's still a nasty bug that makes it look terrible! |
Closing as out of date |
This hides the next to the last tick, since the last tick is always shown.
Before:
After: