feat: PC-13724 Add custom thresholds for SHR #1188
lukasz-dobekrelease-drafter.yml
on: pull_request
update_release_draft
6s
Annotations
2 errors
|
update_release_draft
Validation Failed: {"resource":"Release","code":"invalid","field":"target_commitish"}
{
name: 'HttpError',
id: '10740249807',
status: 422,
response: {
url: 'https://api.github.com/repos/nobl9/nobl9-go/releases/171902158',
status: 422,
headers: {
'access-control-allow-origin': '*',
'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset',
connection: 'close',
'content-length': '210',
'content-security-policy': "default-src 'none'",
'content-type': 'application/json; charset=utf-8',
date: 'Fri, 06 Sep 2024 14:33:45 GMT',
'github-authentication-token-expiration': '2025-01-16 00:00:00 +0100',
'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
server: 'github.com',
'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
vary: 'Accept-Encoding, Accept, X-Requested-With',
'x-accepted-github-permissions': 'contents=write',
'x-content-type-options': 'nosniff',
'x-frame-options': 'deny',
'x-github-api-version-selected': '2022-11-28',
'x-github-media-type': 'github.v3; format=json',
'x-github-request-id': 'D418:24C9C7:2923E2E:4F6A9D3:66DB12C9',
'x-ratelimit-limit': '5000',
'x-ratelimit-remaining': '4949',
'x-ratelimit-reset': '1725634478',
'x-ratelimit-resource': 'core',
'x-ratelimit-used': '51',
'x-xss-protection': '0'
},
data: {
message: 'Validation Failed',
errors: [
{
resource: 'Release',
code: 'invalid',
field: 'target_commitish'
}
],
documentation_url: 'https://docs.github.com/rest/releases/releases#update-a-release',
status: '422'
}
},
request: {
method: 'PATCH',
url: 'https://api.github.com/repos/nobl9/nobl9-go/releases/171902158',
headers: {
accept: 'application/vnd.github.v3+json',
'user-agent': 'probot/12.2.5 octokit-core.js/3.5.1 Node.js/20.13.1 (linux; x64)',
authorization: 'token [REDACTED]',
'content-type': 'application/json; charset=utf-8'
},
body: `{"body":"# What's Changed\\n\\n## 🚀 Features\\n\\n- feat: Switch to govy for validation (#527) @nieomylnieja\\n\\n## 🧰 Maintenance\\n\\n- chore: Update module golang.org/x/text to v0.18.0 (#535) @renovate\\n- chore: Update dependency yaml to v2.5.1 (#532) @renovate\\n- chore: Update minor and patch Golang dependencies (#491) @renovate\\n","draft":true,"prerelease":false,"make_latest":"true","name":"v0.85.0","tag_name":"v0.85.0","target_commitish":"refs/pull/530/merge"}`,
request: {}
},
event: {
id: '10740249807',
name: 'pull_request',
payload: {
action: 'edited',
changes: {
body: {
from: '## Motivation\r\n' +
'\r\n' +
'Currently, System Health Review report is built using error budget remaining metric. Whether an SLO is marked as Red (Exhausted), Green (Healthy), or Yellow (At Risk) depends upon a static value. This PR opens up a window towards user-defined thresholds. If user decides that SLO should be marked as Healthy when it has more than 50% budget remaining, they will set `spec.systemHealthReview.thresholds.greenGt` field to `0.5`. If user wants to remove AtRisk threshold, they will set `spec.systemHealthReview.thresholds.redLte` to the same value as `greenGt` (`0.5`). Additionally, if users decides that NoData SLOs are supposed to be displayed on their report, a field `ShowNoData` is provided that can be set to true in such case.\r\n' +
'\r\n' +
'## Summary\r\n' +
'\r\n' +
'`Thresholds` object with three fields (`GreenGreaterThan`, `RedLessThanOrEqualTo` and `ShowNoData`) was added to `SystemHealthReviewConfig` along with validation of said f
|
|
update_release_draft
HttpError: Validation Failed: {"resource":"Release","code":"invalid","field":"target_commitish"}
at /home/runner/work/_actions/release-drafter/release-drafter/v6/dist/index.js:8462:21
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async Job.doExecute (/home/runner/work/_actions/release-drafter/release-drafter/v6/dist/index.js:30793:18)
{
name: 'AggregateError',
event: {
id: '10740249807',
name: 'pull_request',
payload: {
action: 'edited',
changes: {
body: {
from: '## Motivation\r\n' +
'\r\n' +
'Currently, System Health Review report is built using error budget remaining metric. Whether an SLO is marked as Red (Exhausted), Green (Healthy), or Yellow (At Risk) depends upon a static value. This PR opens up a window towards user-defined thresholds. If user decides that SLO should be marked as Healthy when it has more than 50% budget remaining, they will set `spec.systemHealthReview.thresholds.greenGt` field to `0.5`. If user wants to remove AtRisk threshold, they will set `spec.systemHealthReview.thresholds.redLte` to the same value as `greenGt` (`0.5`). Additionally, if users decides that NoData SLOs are supposed to be displayed on their report, a field `ShowNoData` is provided that can be set to true in such case.\r\n' +
'\r\n' +
'## Summary\r\n' +
'\r\n' +
'`Thresholds` object with three fields (`GreenGreaterThan`, `RedLessThanOrEqualTo` and `ShowNoData`) was added to `SystemHealthReviewConfig` along with validation of said fields.\r\n' +
'\r\n' +
'## Release Notes\r\n' +
'\r\n' +
'`Thresholds` object with three fields (`GreenGreaterThan`, `RedLessThanOrEqualTo` and `ShowNoData`) was added to `SystemHealthReviewConfig`. It allows users to define custom values for `Healthy` (`Green`), `AtRisk` (`Yellow`) and `Exhausted` (`Red`) thresholds and to decide whether to display or hide `NoData` SLOs on System Health Review report.'
}
},
number: 530,
organization: {
avatar_url: 'https://avatars.githubusercontent.com/u/58781264?v=4',
description: '',
events_url: 'https://api.github.com/orgs/nobl9/events',
hooks_url: 'https://api.github.com/orgs/nobl9/hooks',
id: 58781264,
issues_url: 'https://api.github.com/orgs/nobl9/issues',
login: 'nobl9',
members_url: 'https://api.github.com/orgs/nobl9/members{/member}',
node_id: 'MDEyOk9yZ2FuaXphdGlvbjU4NzgxMjY0',
public_members_url: 'https://api.github.com/orgs/nobl9/public_members{/member}',
repos_url: 'https://api.github.com/orgs/nobl9/repos',
url: 'https://api.github.com/orgs/nobl9'
},
pull_request: {
_links: {
comments: {
href: 'https://api.github.com/repos/nobl9/nobl9-go/issues/530/comments'
},
commits: {
href: 'https://api.github.com/repos/nobl9/nobl9-go/pulls/530/commits'
},
html: { href: 'https://github.com/nobl9/nobl9-go/pull/530' },
issue: {
href: 'https://api.github.com/repos/nobl9/nobl9-go/issues/530'
},
review_comment: {
href: 'https://api.github.com/repos/nobl9/nobl9-go/pulls/comments{/number}'
},
review_comments: {
href: 'https://api.github.com/repos/nobl9/nobl9-go/pulls/530/comments'
},
self: {
href: 'https://api.github.com/repos/nobl9/nobl9-go/pulls/530'
},
statuses: {
href: 'https://api.github.com/repos/nobl9/nobl9-go/statuses/8ebfeb429d8dbff1e5d515cca912193daa623ecf'
}
},
active_lock_reason: null,
additions: 182,
assignee: null,
assignees: [],
author_association: 'CONTRIBUTOR',
auto_merge: null,
base: {
label: 'nobl9:main',
ref: 'main',
repo: {
allow_auto_merge: true,
a
|