feat: PC-13724 Add custom thresholds for SHR #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasz-dobek
requested review from
nieomylnieja,
skrolikiewicz and
daniel-zelazny
as code owners
…to-customize-thresholds-via-yaml
natalialanga
approved these changes
Sep 3, 2024
lukasz-dobek
changed the title
lukasz-dobek
deleted the
PC-13724-allow-users-to-customize-thresholds-via-yaml
branch
renovate bot
referenced
this pull request
in nobl9/sloctl
Sep 11, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/nobl9/nobl9-go](https://redirect.github.com/nobl9/nobl9-go) | `v0.84.1-rc3` -> `v0.84.1-rc4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>nobl9/nobl9-go (github.com/nobl9/nobl9-go)</summary> ### [`v0.84.1-rc4`](https://redirect.github.com/nobl9/nobl9-go/releases/tag/v0.84.1-rc4) [Compare Source](https://redirect.github.com/nobl9/nobl9-go/compare/v0.84.1-rc3...v0.84.1-rc4) #### What's Changed - chore: Update dependency yaml to v2.5.1 by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/nobl9/nobl9-go/pull/532](https://redirect.github.com/nobl9/nobl9-go/pull/532) - chore: Update module golang.org/x/text to v0.18.0 by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/nobl9/nobl9-go/pull/535](https://redirect.github.com/nobl9/nobl9-go/pull/535) - feat: PC-13724 Add custom thresholds for SHR by [@​lukasz-dobek](https://redirect.github.com/lukasz-dobek) in [https://github.com/nobl9/nobl9-go/pull/530](https://redirect.github.com/nobl9/nobl9-go/pull/530) - chore: Update module golang.org/x/tools/cmd/goimports to v0.25.0 by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/nobl9/nobl9-go/pull/540](https://redirect.github.com/nobl9/nobl9-go/pull/540) - chore: export metric spec validation rules by [@​kuklyy](https://redirect.github.com/kuklyy) in [https://github.com/nobl9/nobl9-go/pull/536](https://redirect.github.com/nobl9/nobl9-go/pull/536) **Full Changelog**: nobl9/nobl9-go@v0.84.1-rc3...v0.84.1-rc4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,before 5am every weekday,every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/nobl9/sloctl). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwiZ29sYW5nIiwicmVub3ZhdGUiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
natalialanga
added a commit
to nobl9/terraform-provider-nobl9
that referenced
this pull request
Sep 23, 2024
## Summary Add support for managing System Health Review Report via terraform. ## Related Changes nobl9/nobl9-go#495 nobl9/nobl9-go#530 ## Testing TBD ## Release Notes Handle creating, updating and deleting reports. Only System Health Review report type is currently supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, System Health Review report is built using error budget remaining metric. Whether an SLO is marked as Red (Exhausted), Green (Healthy), or Yellow (At Risk) depends upon a static value. This PR opens up a window towards user-defined thresholds. If user decides that SLO should be marked as Healthy when it has more than 50% budget remaining, they will set
spec.systemHealthReview.thresholds.greenGtfield to0.5. If user wants to remove AtRisk threshold, they will setspec.systemHealthReview.thresholds.redLteto the same value asgreenGt(0.5). Additionally, if users decides that NoData SLOs are supposed to be displayed on their report, a fieldShowNoDatais provided that can be set to true in such case.Summary
Thresholdsobject with three fields (GreenGreaterThan,RedLessThanOrEqualToandShowNoData) was added toSystemHealthReviewConfigalong with validation of said fields.Release Notes
Thresholdsobject with three fields (GreenGreaterThan,RedLessThanOrEqualToandShowNoData) was added toSystemHealthReviewConfig. It allows users to define custom values forHealthy(Green),AtRisk(Yellow) andExhausted(Red) thresholds and to decide whether to display or hideNoDataSLOs on System Health Review report. It will be available once Nobl9 platform version 1.97.2 is released.