Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order of logging calls in handler startup code #733

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Fix order of logging calls in handler startup code #733

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,8 +192,8 @@ func main() {
// Check that nmstatectl is working
_, err := nmstatectl.Show()
if err != nil {
os.Exit(1)
setupLog.Error(err, "failed checking nmstatectl health")
os.Exit(1)
}

// Handler runs with host networking so opening ports is problematic
Expand All @@ -204,8 +204,8 @@ func main() {
setupLog.Info("Marking handler as healthy touching healthy file", "healthyFile", healthyFile)
err = file.Touch(healthyFile)
if err != nil {
os.Exit(1)
setupLog.Error(err, "failed marking handler as healthy")
os.Exit(1)
}
}

Expand Down