Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order of logging calls in handler startup code #733

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

cybertron
Copy link
Collaborator

Is this a BUG FIX or a FEATURE ?:

Uncomment only one, leave it on its own line:

/kind bug

/kind enhancement

What this PR does / why we need it:
The previous order of these calls resulted in the container exiting
before the log message was output, which made it impossible to debug
what went wrong. This just changes the order so the message is logged
and then the process exits.

Special notes for your reviewer:

Release note:

Fix logging so the handler process won't exit silently in some error situations.

@kubevirt-bot kubevirt-bot added kind/bug release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Apr 27, 2021
@kubevirt-bot kubevirt-bot requested review from qinqon and rhrazdil April 27, 2021 20:08
@kubevirt-bot kubevirt-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 27, 2021
@kubevirt-bot
Copy link
Collaborator

Hi @cybertron. Thanks for your PR.

I'm waiting for a nmstate member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

The previous order of these calls resulted in the container exiting
before the log message was output, which made it impossible to debug
what went wrong. This just changes the order so the message is logged
and then the process exits.

Signed-off-by: Ben Nemec <[email protected]>
@cybertron cybertron force-pushed the fix-startup-logging branch from 8a099e1 to 45b9cf3 Compare April 27, 2021 20:09
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Apr 27, 2021
@qinqon
Copy link
Member

qinqon commented Apr 28, 2021

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2021
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2021
@kubevirt-bot kubevirt-bot merged commit 6775c14 into nmstate:master Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants