Added tcgetpgrp and tcsetpgrp #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! The implementation looks good to me. Can you do two minor things:
|
|
Sure. I'll get in that. |
|
☔ The latest upstream changes (presumably #449) made this pull request unmergeable. Please resolve the merge conflicts. |
Closed
kamalmarhubi
requested changes
Nov 4, 2016
There was a problem hiding this comment.
This seems fine to me. One small change to tcsetgrp, and then @posborne's request for a changelog entry and docs. If the example docs are to much, just a short one-line would still be useful.
| #[inline] | ||
| pub fn tcsetpgrp(fd: c_int, pgrp: pid_t) -> Result<c_int> { | ||
| let res = unsafe { libc::tcsetpgrp(fd, pgrp) }; | ||
| Errno::result(res) |
There was a problem hiding this comment.
this should have .map(drop), as the return only distinguishes failures.
|
I've made the request changes. |
|
📌 Commit 013e7c8 has been approved by |
kamalmarhubi
approved these changes
Nov 8, 2016
homu
added a commit
that referenced
this pull request
Nov 8, 2016
Added tcgetpgrp and tcsetpgrp I added the tcgetpgrp and tcsetpgrp functions. I'm not sure if I did everything right so please tell me if I need to change anything.
|
💥 Test timed out |
|
@homu retry |
homu
added a commit
that referenced
this pull request
Nov 8, 2016
Added tcgetpgrp and tcsetpgrp I added the tcgetpgrp and tcsetpgrp functions. I'm not sure if I did everything right so please tell me if I need to change anything.
|
☀️ Test successful - status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the tcgetpgrp and tcsetpgrp functions. I'm not sure if I did everything right so please tell me if I need to change anything.