Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tcsetpgrp function #447

Closed
tinywombat765 opened this issue Oct 25, 2016 · 8 comments
Closed

Add tcsetpgrp function #447

tinywombat765 opened this issue Oct 25, 2016 · 8 comments

Comments

@tinywombat765
Copy link
Contributor

Could the tcsetpgrp function please be added? Thank you.

@posborne
Copy link
Member

Certainly, would you mind taking a shot at implementing? I believe this one would be added to unistd.rs. Probably would want to have tcgetpgrp added as well.

Doing this would require two changes:

  1. Add the raw FFI definitions to the libc crate. This would expose and unsafe interface.
  2. Add functions that use these definitions to nix (with a safe interface).

If not, somebody here can probably get to it in time as well.

@tinywombat765
Copy link
Contributor Author

tinywombat765 commented Oct 28, 2016

Okay, I'm on it. Step 1 done.

@posborne
Copy link
Member

Okay, I'm on it. Step 1 done.

Excellent, thanks for the update @zethra

@kamalmarhubi
Copy link
Member

@zethra are you interested in adding it to nix as well? We can walk you through the process!

@tinywombat765
Copy link
Contributor Author

tinywombat765 commented Nov 4, 2016

@kamalmarhubi I've added them to my fork of nix. I'm just working on the documentation. But I'll happily except any help you're willing to give!

@kamalmarhubi
Copy link
Member

Excellent! Feel free to open a PR from your fork and we'll take a look :-)

@kamalmarhubi
Copy link
Member

I'm doing so poorly at keeping track. You already opened #451. Taking a look.

@Susurrus
Copy link
Contributor

Susurrus commented Jun 4, 2017

This was resolved by #451.

@Susurrus Susurrus closed this as completed Jun 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants