plugins/lualine: migrate to mkNeovimPlugin

[khaneliman]

Resolves #2191

Migrating to the current standards. Required using a transitionType for the component options that will help keep existing configurations working, but recommend switching to the new way of being explicit in your configuration to match upstream plugin declaration.

[MattSturgeon]

Everything looks good, IDK if you want a second opinion, but you've been very thorough in checking upstream options so I trust your changes 🚀

[khaneliman]

Everything looks good, IDK if you want a second opinion, but you've been very thorough in checking upstream options so I trust your changes 🚀

Thanks, I'm fairly confident in the changes since it works with my config and I'd consider it robust. Was just double checking the diff a bit and everything looks pretty good.

[khaneliman]

@Mergifyio queue

[mergify]

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at d12045e

[SuperSandro2000]

I don't think the mkRenamedOptions is working correctly here

       error: A definition for option `programs.nixvim.plugins.lualine.settings.sections.lualine_b' is not of type `null or (list of (string or ((attribute set of anything) or raw lua code))) or raw lua code'. Definition values:
       - In `/nix/store/y93lbhv6j469navzizc944gvgc5hcn4v-source/plugins/by-name/lualine':

[MattSturgeon]

I don't think the mkRenamedOptions is working correctly here

       error: A definition for option `programs.nixvim.plugins.lualine.settings.sections.lualine_b' is not of type `null or (list of (string or ((attribute set of anything) or raw lua code))) or raw lua code'. Definition values:
       - In `/nix/store/y93lbhv6j469navzizc944gvgc5hcn4v-source/plugins/by-name/lualine':

Thanks for reporting. What does the offending definition look like?

[MattSturgeon]

This doesn't make much sense, because the new type should be a superset of the old type.

# new type:
null or (list of (string or ((attribute set of anything) or raw lua code))) or raw lua code

# old type:
null or (list of (string or (submodule)))

[SuperSandro2000]

Thanks for reporting. What does the offending definition look like?

That is the old config https://github.com/NuschtOS/nvim.nix/blob/4aae65ffea0b488803245fd27e6ef5812faa5fa7/modules/default.nix#L79-L92

My attempt at updating is at NuschtOS/nvim.nix@d11ad57 (#47)

[khaneliman]

Thanks for reporting. What does the offending definition look like?

That is the old config https://github.com/NuschtOS/nvim.nix/blob/4aae65ffea0b488803245fd27e6ef5812faa5fa7/modules/default.nix#L79-L92

My attempt at updating is at NuschtOS/nvim.nix@d11ad57 (#47)

I created test cases for both configs and they worked: https://github.com/nix-community/nixvim/compare/main...khaneliman:nixvim:sandro?expand=1

Running the old config:

Testing and running the new config worked without the warnings. Wondering if there's something else going on then...