vimPlugins.lualine-nvim: add nvim-web-devicons dependency #337579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Listed as a requirement on their documentation https://github.com/nvim-lualine/lualine.nvim
MattSturgeon
approved these changes
Aug 26, 2024
|
Result of 2 packages built:
|
This says if. I don’t want them. |
13 tasks
toastal
added a commit
to toastal/nixpkgs
that referenced
this pull request
Aug 29, 2024
This reverts commit 7bbb7d3 @ NixOS#337579 The premise that the docs shows this as a requirement is incorrect. The docs state that it is optional saying > " If you want to have icons in your statusline choose one of these *If* is the keyword here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listed as a requirement on their documentation
https://github.com/nvim-lualine/lualine.nvim and can remove requiring adding it in nixvim nix-community/nixvim#2080
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.