neovim: un-deprecate the configure option (backport)
#978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalbasit
approved these changes
Jan 8, 2020
|
Definitely use `-x` 🙂
…On 8 January 2020 07:22:58 CET, Wael Nasreddine ***@***.***> wrote:
@rissson the cherry-picked commit does not refer to the original
commit. Running the cherry-pick with the `-x` option adds the original
commit sha to the description of the cherry-picked commit. This is how
it's done nixpkgs side, unsure if @rycee would like to enforce it
though.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#978 (comment)
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
jorsn
pushed a commit
to jorsn/home-manager
that referenced
this pull request
Apr 25, 2020
The `programs.neovim.configure` option is consistent with NixOS's `wrapNeovim` and offers features not supported by the `extraConfig` and `plugins` option pair. Closes nix-community#971 (cherry picked from commit 1b7b1bc) Co-authored-by: Wael Nasreddine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a back-porting of #971
Closes kalbasit/shabka#286
Mentioning participants:
@rycee
@Gerschtli
@kalbasit