un-deprecate programs.neovim.configure #971
Comments
|
Hey, as I was the one introducing this deprecation: I think we should remove the deprecation warning and let the use decide on how he configures neovim. The reason why I added the deprecation warning was consistency between vim and neovim modules and because I thought there were no benefit in supporting the As you proved me wrong and there were some other concerns regarding plugin loading order of vim plugins (cannot remember the thread we discussed it, see below ), let's simply remove the deprecation warning. EDIT: I meant #815 which was not related to this change. I remembered incorrectly. |
|
Hey. Sounds good to me. I'll file a PR. |
kalbasit
added a commit
to kalbasit/home-manager
that referenced
this issue
Jan 4, 2020
The `programs.neovim.configure` option is consistent with NixOS's `wrapNeovim`. closes nix-community#971
kalbasit
added a commit
that referenced
this issue
Jan 6, 2020
The `programs.neovim.configure` option is consistent with NixOS's `wrapNeovim` and offers features not supported by the `extraConfig` and `plugins` option pair. Closes #971
teto
pushed a commit
that referenced
this issue
Jan 9, 2020
The `programs.neovim.configure` option is consistent with NixOS's `wrapNeovim` and offers features not supported by the `extraConfig` and `plugins` option pair. Closes #971 (cherry picked from commit 1b7b1bc) Co-authored-by: Wael Nasreddine <[email protected]>
jorsn
pushed a commit
to jorsn/home-manager
that referenced
this issue
Apr 25, 2020
The `programs.neovim.configure` option is consistent with NixOS's `wrapNeovim` and offers features not supported by the `extraConfig` and `plugins` option pair. Closes nix-community#971 (cherry picked from commit 1b7b1bc) Co-authored-by: Wael Nasreddine <[email protected]>
jorsn
pushed a commit
to jorsn/home-manager
that referenced
this issue
Apr 25, 2020
The `programs.neovim.configure` option is consistent with NixOS's `wrapNeovim` and offers features not supported by the `extraConfig` and `plugins` option pair. Closes nix-community#971
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@rycee what was the motivation for deprecating the
configureoption?In shabka, we declare a common neovim configuration module that are being used directly for configuring NixOS and home-manager. It would be a shame to lose this consistency.
We're currently this in kalbasit/shabka#286
Originally posted by @kalbasit in #793
The text was updated successfully, but these errors were encountered: