Open package.toml file with UTF8 locale #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
earlbread
force-pushed
the
fix-toml-encoding
branch
3 times, most recently
from
f4fd1b1 to
9fb5063
Compare
dahlia
requested changes
Aug 17, 2018
CHANGES.md
Outdated
| @@ -10,6 +10,8 @@ To be released. | |||
|
|
|||
| - The `uri` type has completly gone; use `url` instead. | |||
| [[#126], [#281] by Jonghun Park] | |||
| - Fixed locale to open package.toml. | |||
There was a problem hiding this comment.
It would be if the changelog specifies the actual behavior it fixed, e.g.:
Fixed a bug that package.toml file had been failed to load when the system locale does not use UTF-8. It's now independent from the system locale settings.
There was a problem hiding this comment.
Sure, I'll fix the changelog and rebase it!
earlbread
force-pushed
the
fix-toml-encoding
branch
from
9fb5063 to
1829296
Compare
earlbread
force-pushed
the
fix-toml-encoding
branch
from
1829296 to
8f511a4
Compare
Codecov Report
@@ Coverage Diff @@
## 0.4-maintenance #322 +/- ##
===================================================
- Coverage 77.19% 76.13% -1.06%
===================================================
Files 34 34
Lines 2670 2908 +238
Branches 144 195 +51
===================================================
+ Hits 2061 2214 +153
- Misses 465 499 +34
- Partials 144 195 +51
Continue to review full report at Codecov.
|
dahlia
added a commit
that referenced
this pull request
Aug 18, 2018
Open package.toml file with UTF8 locale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #290