Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOML reading should be independent from locale settings #290

Closed
dahlia opened this issue Jul 18, 2018 · 2 comments
Closed

TOML reading should be independent from locale settings #290

dahlia opened this issue Jul 18, 2018 · 2 comments
Labels
cmp:frontend Component: Compiler frontend (e.g., CLI, parser, AST) dfct:easy Difficulty: Easy typ:bug Type: Bug/defect

Comments

@dahlia
Copy link
Member

dahlia commented Jul 18, 2018

According to TOML specification:

A TOML file must be a valid UTF-8 encoded Unicode document.

The current implementation implicitly decodes the bytes from a package.toml file according to the system locale settings (e.g., LOCALE, LC_ALL).

Scan error: ./package.toml: hGetContents: invalid argument (invalid byte sequence)
@dahlia dahlia added typ:bug Type: Bug/defect dfct:easy Difficulty: Easy cmp:frontend Component: Compiler frontend (e.g., CLI, parser, AST) labels Jul 18, 2018
@AlanSynn
Copy link
Contributor

on going

@AlanSynn
Copy link
Contributor

AlanSynn commented Aug 17, 2018

Couldn't get approaches to set LOCALEs on mac. (e.g. Latin1, EUC-KR, CP949)
If you want to make a further progress, then set a docker environment for Linux.

Further Progress
The experiment should be performed with package.yaml containing some non-ascii characters.
Reproduced on Linux(Docker), not on OSX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmp:frontend Component: Compiler frontend (e.g., CLI, parser, AST) dfct:easy Difficulty: Easy typ:bug Type: Bug/defect
Projects
None yet
Development

No branches or pull requests

2 participants