Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picks #115

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Picks #115

merged 3 commits into from
Nov 30, 2023

Conversation

Sayamame-beans
Copy link

What

Why

Additional info (optional)

cherry-pick初挑戦なのでミスあったら指摘してください。

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

samunohito and others added 3 commits November 30, 2023 18:15
Copy link

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

Copy link
Collaborator

@anatawa12 anatawa12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -5,6 +5,12 @@ SPDX-License-Identifier: AGPL-3.0-only

<template>
<div class="_gaps_m">
<MkSwitch v-model="notUseSound">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これでupstream通ったんだ(2つのトグルなの少し違和感)だけどupstreamの問題なのでここではOK

@Sayamame-beans Sayamame-beans merged commit be5e0aa into niri-la:develop Nov 30, 2023
18 checks passed
@Sayamame-beans Sayamame-beans deleted the picks branch November 30, 2023 10:06
anatawa12 added a commit that referenced this pull request Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants