Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): ハイライトするノートがない場合は直近のノートにフォールバックする #113

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

anatawa12
Copy link
Collaborator

What

misskey-dev#12437

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@anatawa12
Copy link
Collaborator Author

あーこのままじゃダメだ

Copy link

github-actions bot commented Nov 30, 2023

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

@anatawa12 anatawa12 changed the title Fallback to newest notes fix(frontend): ハイライトするノートがない場合は直近のノートにフォールバックする Nov 30, 2023
Copy link

@Sayamame-beans Sayamame-beans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多分ヨシ?
includeSensitiveChannelがuser/notesの方に指定無いのは問題無し?

@anatawa12
Copy link
Collaborator Author

あーあったほうがいいね

@anatawa12
Copy link
Collaborator Author

というかfeatuerdにはincludeSensitiveChannelないね...

@Sayamame-beans 追加しちゃったけどどちらもなしでもいい気がしてきた

Copy link

@Sayamame-beans Sayamame-beans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそう

@anatawa12 anatawa12 force-pushed the fallback-to-newest-notes branch from 8f0b47f to 65e4140 Compare November 30, 2023 07:10
@anatawa12
Copy link
Collaborator Author

なくしました

@Sayamame-beans
Copy link

あ、了解です

@anatawa12 anatawa12 merged commit 001d244 into niri-la:develop Nov 30, 2023
18 checks passed
@anatawa12 anatawa12 deleted the fallback-to-newest-notes branch November 30, 2023 07:27
@anatawa12 anatawa12 mentioned this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants