-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(frontend): ハイライトするノートがない場合は直近のノートにフォールバックする #12437
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #12437 +/- ##
===========================================
- Coverage 78.67% 78.64% -0.03%
===========================================
Files 951 950 -1
Lines 103424 103315 -109
Branches 8330 8331 +1
===========================================
- Hits 81365 81257 -108
+ Misses 22059 22058 -1 ☔ View full report in Codecov by Sentry. |
This was referenced Nov 30, 2023
anatawa12
added a commit
to niri-la/misskey.niri.la
that referenced
this pull request
Nov 30, 2023
…113) * (fix) ハイライトがない場合は直近のノートにフォールバック * Update Changelog * chore: 使われていないincludeSensitiveChannel指定を削除 --------- Co-authored-by: kakkokari-gtyih <[email protected]>
syuilo
reviewed
Dec 2, 2023
@@ -133,7 +133,11 @@ SPDX-License-Identifier: AGPL-3.0-only | |||
</template> | |||
<div v-if="!disableNotes"> | |||
<div style="margin-bottom: 8px;">{{ i18n.ts.featured }}</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ここもよしなに変えないと不自然かも
概要ページのユーザーTLが選択可能になったのでClose |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
リモートユーザーなどで、ハイライトするノートがない場合は、直近のノートを表示するようにフォールバックする
Why
Fix #12084
Additional info (optional)
Checklist