Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): ハイライトするノートがない場合は直近のノートにフォールバックする #12437

Closed

Conversation

kakkokari-gtyih
Copy link
Contributor

What

リモートユーザーなどで、ハイライトするノートがない場合は、直近のノートを表示するようにフォールバックする

Why

Fix #12084

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Nov 24, 2023
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (c927d68) 78.67% compared to head (12b09ca) 78.64%.

Files Patch % Lines
packages/frontend/src/pages/user/home.vue 78.94% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12437      +/-   ##
===========================================
- Coverage    78.67%   78.64%   -0.03%     
===========================================
  Files          951      950       -1     
  Lines       103424   103315     -109     
  Branches      8330     8331       +1     
===========================================
- Hits         81365    81257     -108     
+ Misses       22059    22058       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

anatawa12 added a commit to niri-la/misskey.niri.la that referenced this pull request Nov 30, 2023
…113)

* (fix) ハイライトがない場合は直近のノートにフォールバック

* Update Changelog

* chore: 使われていないincludeSensitiveChannel指定を削除

---------

Co-authored-by: kakkokari-gtyih <[email protected]>
@@ -133,7 +133,11 @@ SPDX-License-Identifier: AGPL-3.0-only
</template>
<div v-if="!disableNotes">
<div style="margin-bottom: 8px;">{{ i18n.ts.featured }}</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここもよしなに変えないと不自然かも

@kakkokari-gtyih
Copy link
Contributor Author

概要ページのユーザーTLが選択可能になったのでClose

@kakkokari-gtyih kakkokari-gtyih deleted the fix-12084 branch December 16, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2023.10.1〜]リモートユーザーのページのファーストビューにノートが乗らない
2 participants