Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More on #16110 #16130

Merged
merged 6 commits into from
Nov 26, 2020
Merged

More on #16110 #16130

merged 6 commits into from
Nov 26, 2020

Conversation

cooldome
Copy link
Member

@cooldome cooldome commented Nov 25, 2020

My previous fix for #16110 caused pragmas to dissappear from AST.
More tests, preserve pragmas.

@Clyybber
Copy link
Contributor

This doesn't fix PtrTy still existing in the ast

@cooldome
Copy link
Member Author

Good point, fixed it. Test added

@cooldome cooldome merged commit 2f1a9ea into devel Nov 26, 2020
@Araq Araq deleted the fix_16110_2 branch November 26, 2020 18:31
mildred pushed a commit to mildred/Nim that referenced this pull request Jan 11, 2021
* fix nim-lang#16110

* refs nim-lang#16110

* fix comment

* Trigger build

* use shallowCopy for efficiency
ardek66 pushed a commit to ardek66/Nim that referenced this pull request Mar 26, 2021
* fix nim-lang#16110

* refs nim-lang#16110

* fix comment

* Trigger build

* use shallowCopy for efficiency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants